From: Pekka Hyvönen <pekka@vaadin.com>
Date: Fri, 8 May 2015 07:43:37 +0000 (+0300)
Subject: Fixed regression in details row for IE8&9 and another small bug (#17423)
X-Git-Tag: 7.5.0.beta1~23
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=26087a85313cdf0be8cb7ee4dea5cf90e4e130ec;p=vaadin-framework.git

Fixed regression in details row for IE8&9 and another small bug (#17423)

Regression caused by the previous patch for the ticket. Details row inherited extra margin-top from parent.
Because some position functions in escalator use left for transforming the rows, the offset caused
by the spacer deco was switched to padding-left from left, so it won't get overridden by the position
funcion.

Change-Id: I774ab9573c95f971a0e625dc8d79370f3d86daec
---

diff --git a/WebContent/VAADIN/themes/base/escalator/escalator.scss b/WebContent/VAADIN/themes/base/escalator/escalator.scss
index 73d45854b9..2d5ad729fc 100644
--- a/WebContent/VAADIN/themes/base/escalator/escalator.scss
+++ b/WebContent/VAADIN/themes/base/escalator/escalator.scss
@@ -145,5 +145,12 @@
       @include box-sizing(border-box);
     }
     
+    .v-ie8 &, .v-ie9 & {
+      // The inline style of margin-top from the <tbody> to offset the
+      // header's dimension is, for some strange reason, inherited into each
+      // contained <tr>. We need to cancel it:
+
+      margin-top: 0;
+    }
   }
 }
diff --git a/WebContent/VAADIN/themes/base/grid/grid.scss b/WebContent/VAADIN/themes/base/grid/grid.scss
index 531abb1ff1..ede4ccca0d 100644
--- a/WebContent/VAADIN/themes/base/grid/grid.scss
+++ b/WebContent/VAADIN/themes/base/grid/grid.scss
@@ -437,9 +437,10 @@ $v-grid-details-border-bottom-stripe: 1px solid darken($v-grid-row-background-co
   }
 
   .#{$primaryStyleName}-spacer {
-    left: $v-grid-details-marker-width - $v-grid-border-size;
+    // using padding since left is used with some position functions in escalator
+    padding-left: $v-grid-details-marker-width - $v-grid-border-size;
   }
-  
+
   .#{$primaryStyleName}-spacer > td {
     display: block;
     padding: 0;