From: Julien Lancelot <julien.lancelot@gmail.com>
Date: Thu, 13 Jun 2013 14:31:36 +0000 (+0200)
Subject: SONAR-4301 Remove order by id desc because it generates an important overhead
X-Git-Tag: 3.7~489
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=27576858612f0d5a141ce71b2862ff6c906dabfb;p=sonarqube.git

SONAR-4301 Remove order by id desc because it generates an important overhead
---

diff --git a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
index 1495d7bf359..aff84d57572 100644
--- a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
+++ b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
@@ -199,7 +199,6 @@
         </foreach>
       </foreach>
     </where>
-    order by i.id desc
   </select>
 
   <select id="selectIssues" parameterType="map" resultType="Issue" fetchSize="100000">
@@ -307,7 +306,6 @@
         and i.issue_creation_date &lt; #{query.createdBefore}
       </if>
     </where>
-    order by i.id desc
   </sql>
 
 </mapper>
diff --git a/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java b/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java
index 504e475cdc3..a792176d525 100644
--- a/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java
+++ b/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java
@@ -90,18 +90,6 @@ public class IssueDaoTest extends AbstractDaoTestCase {
     assertThat(issue.getId()).isNotNull();
   }
 
-  @Test
-  public void should_select_issues_sort_results_by_id_desc() {
-    setupData("shared", "should_select_all");
-
-    IssueQuery query = IssueQuery.builder().requiredRole("user").build();
-
-    List<IssueDto> results = dao.selectIssues(query);
-    assertThat(results.get(0).getId()).isEqualTo(102);
-    assertThat(results.get(1).getId()).isEqualTo(101);
-    assertThat(results.get(2).getId()).isEqualTo(100);
-  }
-
   @Test
   public void should_select_by_rules() {
     setupData("shared", "should_select_by_rules");
@@ -317,18 +305,6 @@ public class IssueDaoTest extends AbstractDaoTestCase {
     assertThat(results).hasSize(3);
   }
 
-  @Test
-  public void should_select_by_ids_sort_results_by_id_desc() {
-    setupData("shared", "should_select_by_ids");
-
-    List<IssueDto> results = newArrayList(dao.selectByIds(newArrayList(100l, 101l, 102l)));
-
-    assertThat(results.get(0).getId()).isEqualTo(102);
-    assertThat(results.get(1).getId()).isEqualTo(101);
-    assertThat(results.get(2).getId()).isEqualTo(100);
-  }
-
-
   private List<Long> getIssueIds(List<IssueDto> issues) {
     return newArrayList(Iterables.transform(issues, new Function<IssueDto, Long>() {
       @Override