From: Scott González <scott.gonzalez@gmail.com>
Date: Fri, 13 Feb 2009 03:06:43 +0000 (+0000)
Subject: Dialog: Don't set focus to elements in the titlebar on open.  Fixes #4126 - focus... 
X-Git-Tag: 1.6~4
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=2916159a088f20eb33602d69c97b79792dd5c037;p=jquery-ui.git

Dialog: Don't set focus to elements in the titlebar on open.  Fixes #4126 - focus on dialog open should be constrained to the contents of the dialog.

NOTE: This breaks accessibility in Safari, which doesn't allow setting focus to elements that are not natively tabbable.  However, our current stance is that people who require accessibility will not be using Safari specifically for this type of reason.
---

diff --git a/ui/ui.dialog.js b/ui/ui.dialog.js
index f6cd5ac20..4cec0f7f3 100644
--- a/ui/ui.dialog.js
+++ b/ui/ui.dialog.js
@@ -230,14 +230,12 @@ $.widget("ui.dialog", {
 			}
 		}));
 
-		// set focus to the first tabbable element in:
-		// - content area
-		// - button pane
-		// - title bar
+		// set focus to the first tabbable element in the content area or the first button
+		// if there are no tabbable elements, set focus on the dialog itself
 		$([])
 			.add(uiDialog.find('.ui-dialog-content :tabbable:first'))
 			.add(uiDialog.find('.ui-dialog-buttonpane :tabbable:first'))
-			.add(uiDialog.find('.ui-dialog-titlebar :tabbable:first'))
+			.add(uiDialog)
 			.filter(':first')
 			.focus();