From: Dave Methvin <dave.methvin@gmail.com>
Date: Mon, 9 Nov 2015 23:14:59 +0000 (-0500)
Subject: Offset: offsetLeft/Top on empty set returns undefined
X-Git-Tag: 2.2.0~75
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=29370190605ed5ddf5d0371c6ad886a4a4b5e0f9;p=jquery.git

Offset: offsetLeft/Top on empty set returns undefined

Fixes gh-2319
Closes gh-2702
Ref gh-2701
---

diff --git a/src/offset.js b/src/offset.js
index bef2a8fa0..f7ef79c3c 100644
--- a/src/offset.js
+++ b/src/offset.js
@@ -202,7 +202,7 @@ jQuery.each( { scrollLeft: "pageXOffset", scrollTop: "pageYOffset" }, function(
 			} else {
 				elem[ method ] = val;
 			}
-		}, method, val, arguments.length, null );
+		}, method, val, arguments.length );
 	};
 } );
 
diff --git a/test/unit/offset.js b/test/unit/offset.js
index 85f1da65d..a0f253b4e 100644
--- a/test/unit/offset.js
+++ b/test/unit/offset.js
@@ -460,8 +460,8 @@ testIframe( "offset/scroll", "scroll", function( $, win, doc, assert ) {
 	assert.notEqual( $().scrollLeft( 100 ), null, "jQuery().scrollLeft(100) testing setter on empty jquery object" );
 	assert.notEqual( $().scrollTop( null ), null, "jQuery().scrollTop(null) testing setter on empty jquery object" );
 	assert.notEqual( $().scrollLeft( null ), null, "jQuery().scrollLeft(null) testing setter on empty jquery object" );
-	assert.strictEqual( $().scrollTop(), null, "jQuery().scrollTop(100) testing setter on empty jquery object" );
-	assert.strictEqual( $().scrollLeft(), null, "jQuery().scrollLeft(100) testing setter on empty jquery object" );
+	assert.strictEqual( $().scrollTop(), undefined, "jQuery().scrollTop() testing getter on empty jquery object" );
+	assert.strictEqual( $().scrollLeft(), undefined, "jQuery().scrollLeft() testing getter on empty jquery object" );
 
 	// Tests position after parent scrolling (#15239)
 	$( "#scroll-1" ).scrollTop( 0 );