From: jeresig Date: Fri, 5 Mar 2010 05:07:57 +0000 (-0500) Subject: Attempted to fix #6227, not entirely sure if it's a problem as I'm having a hard... X-Git-Tag: 1.4.3rc1~179 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=2c08004f6d4e7f11a875190e132d204a25cb9418;p=jquery.git Attempted to fix #6227, not entirely sure if it's a problem as I'm having a hard time reproducing it. Regardless, the change is harmless and potentially even speeds up appendTo, etc. slightly. --- diff --git a/src/manipulation.js b/src/manipulation.js index 7dc813689..13f5ec688 100644 --- a/src/manipulation.js +++ b/src/manipulation.js @@ -442,7 +442,7 @@ jQuery.each({ } else { for ( var i = 0, l = insert.length; i < l; i++ ) { var elems = (i > 0 ? this.clone(true) : this).get(); - jQuery.fn[ original ].apply( jQuery(insert[i]), elems ); + jQuery.fn[ original ].call( jQuery(insert[i]), elems ); ret = ret.concat( elems ); } diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js index d88400d1f..e86eb3b83 100644 --- a/test/unit/manipulation.js +++ b/test/unit/manipulation.js @@ -376,13 +376,21 @@ test("append(Function) with incoming value", function() { }); test("appendTo(String|Element|Array<Element>|jQuery)", function() { - expect(14); + expect(16); var defaultText = 'Try them out:' jQuery('buga').appendTo('#first'); equals( jQuery("#first").text(), defaultText + 'buga', 'Check if text appending works' ); equals( jQuery('').appendTo('#select3').parent().find('option:last-child').attr('value'), 'appendTest', 'Appending html options to select element'); + reset(); + var l = jQuery("#first").children().length + 3; + jQuery("body").map(function(){ + return jQuery("").get(); + }).appendTo("p"); + equals( jQuery("#first").children().length, l, "Make sure the elements were inserted." ); + equals( jQuery("#first").children().last()[0].nodeName.toLowerCase(), "b", "Verify the last element." ); + reset(); var expected = "This link has class=\"blog\": Simon Willison's WeblogTry them out:"; jQuery(document.getElementById('first')).appendTo('#sap');