From: Grégoire Aubert Date: Tue, 12 Jun 2018 15:13:32 +0000 (+0200) Subject: SONARCLOUD-63 SONARCLOUD-74 Return Prismic access token from api/navigation/global X-Git-Tag: 7.5~958 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=30016cd347d9715bfb722b70feeaa90fbb8cda17;p=sonarqube.git SONARCLOUD-63 SONARCLOUD-74 Return Prismic access token from api/navigation/global --- diff --git a/server/sonar-process/src/main/java/org/sonar/process/ProcessProperties.java b/server/sonar-process/src/main/java/org/sonar/process/ProcessProperties.java index bb23304fbb3..6c5deb927c7 100644 --- a/server/sonar-process/src/main/java/org/sonar/process/ProcessProperties.java +++ b/server/sonar-process/src/main/java/org/sonar/process/ProcessProperties.java @@ -108,6 +108,9 @@ public class ProcessProperties { SONAR_UPDATECENTER_ACTIVATE("sonar.updatecenter.activate", "true"), SONARCLOUD_ENABLED("sonar.sonarcloud.enabled", "false"), + + SONAR_PRISMIC_ACCESS_TOKEN("sonar.prismic.accessToken", ""), + BITBUCKETCLOUD_APP_KEY("sonar.bitbucketcloud.appKey", "sonarcloud"), BITBUCKETCLOUD_ENDPOINT("sonar.bitbucketcloud.endpoint", "https://api.bitbucket.org"), diff --git a/server/sonar-server/src/main/java/org/sonar/server/ui/ws/GlobalAction.java b/server/sonar-server/src/main/java/org/sonar/server/ui/ws/GlobalAction.java index 644f10c8c4a..f69de5baed5 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/ui/ws/GlobalAction.java +++ b/server/sonar-server/src/main/java/org/sonar/server/ui/ws/GlobalAction.java @@ -51,6 +51,8 @@ import static org.sonar.core.config.WebConstants.SONAR_LF_ENABLE_GRAVATAR; import static org.sonar.core.config.WebConstants.SONAR_LF_GRAVATAR_SERVER_URL; import static org.sonar.core.config.WebConstants.SONAR_LF_LOGO_URL; import static org.sonar.core.config.WebConstants.SONAR_LF_LOGO_WIDTH_PX; +import static org.sonar.process.ProcessProperties.Property.SONARCLOUD_ENABLED; +import static org.sonar.process.ProcessProperties.Property.SONAR_PRISMIC_ACCESS_TOKEN; import static org.sonar.process.ProcessProperties.Property.SONAR_UPDATECENTER_ACTIVATE; public class GlobalAction implements NavigationWsAction, Startable { @@ -96,6 +98,10 @@ public class GlobalAction implements NavigationWsAction, Startable { @Override public void start() { this.systemSettingValuesByKey.put(SONAR_UPDATECENTER_ACTIVATE.getKey(), config.get(SONAR_UPDATECENTER_ACTIVATE.getKey()).orElse(null)); + boolean isOnSonarCloud = config.getBoolean(SONARCLOUD_ENABLED.getKey()).orElse(false); + if (isOnSonarCloud) { + this.systemSettingValuesByKey.put(SONAR_PRISMIC_ACCESS_TOKEN.getKey(), config.get(SONAR_PRISMIC_ACCESS_TOKEN.getKey()).orElse(null)); + } } @Override diff --git a/server/sonar-server/src/test/java/org/sonar/server/ui/ws/GlobalActionTest.java b/server/sonar-server/src/test/java/org/sonar/server/ui/ws/GlobalActionTest.java index d70c3b92fdf..b0cb60037e9 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/ui/ws/GlobalActionTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/ui/ws/GlobalActionTest.java @@ -126,6 +126,19 @@ public class GlobalActionTest { "}"); } + @Test + public void return_prismic_setting_on_sonarcloud_only() { + settings.setProperty("sonar.sonarcloud.enabled", true); + settings.setProperty("sonar.prismic.accessToken", "secret"); + init(); + + assertJson(call()).isSimilarTo("{" + + " \"settings\": {" + + " \"sonar.prismic.accessToken\": \"secret\"" + + " }" + + "}"); + } + @Test public void return_deprecated_logo_settings() { init();