From: Stas Vilchik <vilchiks@gmail.com>
Date: Fri, 29 Jul 2016 08:13:51 +0000 (+0200)
Subject: SONAR-7926 remove redundant condition
X-Git-Tag: 6.1-RC1~494
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=30b1e36d9b882350e1c3e35cde4d20a0b69e9c7f;p=sonarqube.git

SONAR-7926 remove redundant condition
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/projectlink/ws/CreateAction.java b/server/sonar-server/src/main/java/org/sonar/server/projectlink/ws/CreateAction.java
index 12186285a0d..bdc7906209d 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/projectlink/ws/CreateAction.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/projectlink/ws/CreateAction.java
@@ -116,21 +116,12 @@ public class CreateAction implements ProjectLinksWsAction {
   }
 
   private static CreateWsResponse buildResponse(ComponentLinkDto link) {
-    CreateWsResponse.Builder response = CreateWsResponse.newBuilder();
-
-    WsProjectLinks.Link.Builder linkBuilder = WsProjectLinks.Link.newBuilder()
+    return CreateWsResponse.newBuilder().setLink(WsProjectLinks.Link.newBuilder()
       .setId(String.valueOf(link.getId()))
       .setName(link.getName())
-      .setUrl(link.getHref());
-
-    String type = link.getType();
-    if (type != null) {
-      linkBuilder.setType(type);
-    }
-
-    response.setLink(linkBuilder);
-
-    return response.build();
+      .setType(link.getType())
+      .setUrl(link.getHref()))
+      .build();
   }
 
   private ComponentDto getComponentByUuidOrKey(DbSession dbSession, CreateWsRequest request) {