From: Simon Pepping <spepping@apache.org>
Date: Fri, 18 Feb 2011 08:18:04 +0000 (+0000)
Subject: Fixing checkstyle errors and hiding fingbugs errors
X-Git-Tag: fop-1_1rc1old~276
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=32d5f37b494f99c2c27b39da9254240f84bade03;p=xmlgraphics-fop.git

Fixing checkstyle errors and hiding fingbugs errors

git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1071912 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/findbugs-exclude.xml b/findbugs-exclude.xml
index 116d45951..318fb06cc 100644
--- a/findbugs-exclude.xml
+++ b/findbugs-exclude.xml
@@ -5019,4 +5019,51 @@
       <Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
    </Match>
    <!-- /Automatically generated list of exclusions -->
+   <!-- Automatically generated list of exclusions on 18 February 2011 -->
+   <Match>
+	 <Class name="org.apache.fop.afp.goca.GraphicsSetProcessColor"/>
+	 <Method name="writeToStream"/>
+	 <Bug pattern="OS_OPEN_STREAM"/>
+   </Match>
+   <Match>
+	 <Class name="org.apache.fop.pdf.PDFFactory"/>
+	 <Method name="makeSeparationColorSpace"/>
+	 <Bug pattern="DM_FP_NUMBER_CTOR"/>
+   </Match>
+   <Match>
+	 <Class name="org.apache.fop.pdf.PDFFactory"/>
+	 <Method name="toColorVector"/>
+	 <Bug pattern="DM_FP_NUMBER_CTOR"/>
+   </Match>
+   <Match>
+	 <Class name="org.apache.fop.fo.expr.PropertyTokenizer"/>
+	 <Field name="recognizeOperator"/>
+	 <Bug pattern="URF_UNREAD_FIELD"/>
+   </Match>
+   <Match>
+	 <Class name="org.apache.fop.layoutmgr.BlockLayoutManager"/>
+	 <Method name="getNextChildElements"/>
+	 <Bug pattern="BC_UNCONFIRMED_CAST"/>
+   </Match>
+   <Match>
+	 <Class name="org.apache.fop.util.ColorWithFallback"/>
+	 <!-- Listing the method 'equals' does not work -->
+	 <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
+   </Match>
+   <Match>
+	 <Class name="org.apache.fop.util.ColorWithFallback"/>
+	 <Method name="getAlternativeColors"/>
+	 <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS"/>
+   </Match>
+   <Match>
+	 <Class name="org.apache.fop.fo.expr.NamedColorFunction"/>
+	 <Method name="eval"/>
+	 <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
+   </Match>
+   <Match>
+	 <Class name="org.apache.fop.util.ColorUtil"/>
+	 <Method name="parseAsFopRgbNamedColor"/>
+	 <Bug pattern="REC_CATCH_EXCEPTION"/>
+   </Match>
+   <!-- /Automatically generated list of exclusions on 18 February 2011 -->
 </FindBugsFilter>
\ No newline at end of file
diff --git a/src/java/org/apache/fop/render/pdf/PDFImageHandlerSVG.java b/src/java/org/apache/fop/render/pdf/PDFImageHandlerSVG.java
index 5258d75fb..d47142fb6 100644
--- a/src/java/org/apache/fop/render/pdf/PDFImageHandlerSVG.java
+++ b/src/java/org/apache/fop/render/pdf/PDFImageHandlerSVG.java
@@ -60,7 +60,8 @@ public class PDFImageHandlerSVG implements ImageHandler {
     private static Log log = LogFactory.getLog(PDFImageHandlerSVG.class);
 
     /** {@inheritDoc} */
-    public void handleImage(RenderingContext context, Image image, Rectangle pos)
+    public void handleImage(RenderingContext context,                // CSOK: MethodLength
+                            Image image, Rectangle pos)
                 throws IOException {
         PDFRenderingContext pdfContext = (PDFRenderingContext)context;
         PDFContentGenerator generator = pdfContext.getGenerator();