From: martinf55 <martinf55@hotmail.com>
Date: Mon, 7 May 2012 10:28:47 +0000 (+0200)
Subject: Sortable: Moved change of helper position css. Fixed #5321 – Helper in a bottom-posit... 
X-Git-Tag: 1.9.0m8~43
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=32f356bbfa9a8f3b90b4e64331e9108b4d87a349;p=jquery-ui.git

Sortable: Moved change of helper position css. Fixed #5321 – Helper in a bottom-positioned Sortable is positioned wrong on drag start.
---

diff --git a/ui/jquery.ui.sortable.js b/ui/jquery.ui.sortable.js
index 06df7971f..8ebd3b69c 100644
--- a/ui/jquery.ui.sortable.js
+++ b/ui/jquery.ui.sortable.js
@@ -154,11 +154,6 @@ $.widget("ui.sortable", $.ui.mouse, {
 			left: this.offset.left - this.margins.left
 		};
 
-		// Only after we got the offset, we can change the helper's position to absolute
-		// TODO: Still need to figure out a way to make relative sorting possible
-		this.helper.css("position", "absolute");
-		this.cssPosition = this.helper.css("position");
-
 		$.extend(this.offset, {
 			click: { //Where the click happened, relative to the element
 				left: event.pageX - this.offset.left,
@@ -168,6 +163,11 @@ $.widget("ui.sortable", $.ui.mouse, {
 			relative: this._getRelativeOffset() //This is a relative to absolute position minus the actual position calculation - only used for relative positioned helper
 		});
 
+		// Only after we got the offset, we can change the helper's position to absolute
+		// TODO: Still need to figure out a way to make relative sorting possible
+		this.helper.css("position", "absolute");
+		this.cssPosition = this.helper.css("position");
+		
 		//Generate the original position
 		this.originalPosition = this._generatePosition(event);
 		this.originalPageX = event.pageX;