From: Jean-Philippe Lang Date: Sun, 23 Jul 2017 16:13:25 +0000 (+0000) Subject: Remove ActiveRecord workaround (#26323). X-Git-Tag: 4.0.0~596 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=3320e651d36b0c44e1f3f5366082c0d184408f6f;p=redmine.git Remove ActiveRecord workaround (#26323). git-svn-id: http://svn.redmine.org/redmine/trunk@16869 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- diff --git a/app/models/query.rb b/app/models/query.rb index fc6f97a6c..b297a6973 100644 --- a/app/models/query.rb +++ b/app/models/query.rb @@ -934,12 +934,7 @@ class Query < ActiveRecord::Base def grouped_query(&block) r = nil if grouped? - begin - # Rails3 will raise an (unexpected) RecordNotFound if there's only a nil group value - r = yield base_group_scope - rescue ActiveRecord::RecordNotFound - r = {nil => yield(base_scope)} - end + r = yield base_group_scope c = group_by_column if c.is_a?(QueryCustomFieldColumn) r = r.keys.inject({}) {|h, k| h[c.custom_field.cast_value(k)] = r[k]; h}