From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Mon, 16 Jan 2012 17:52:54 +0000 (+0000)
Subject: Skip a bunch of useless "UPDATE repositories SET extra_info = ..." queries when navig... 
X-Git-Tag: 1.4.0~637
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=34d168308703266950730555efe47d6375e84e7a;p=redmine.git

Skip a bunch of useless "UPDATE repositories SET extra_info = ..." queries when navigating in repositories.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8658 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/models/repository.rb b/app/models/repository.rb
index 00acbb540..02d9fc6c8 100644
--- a/app/models/repository.rb
+++ b/app/models/repository.rb
@@ -101,9 +101,13 @@ class Repository < ActiveRecord::Base
   end
 
   def scm
-    @scm ||= self.scm_adapter.new(url, root_url,
+    unless @scm
+      @scm = self.scm_adapter.new(url, root_url,
                                   login, password, path_encoding)
-    update_attribute(:root_url, @scm.root_url) if root_url.blank?
+      if root_url.blank? && @scm.root_url.present?
+        update_attribute(:root_url, @scm.root_url)
+      end
+    end
     @scm
   end