From: Henri Sara Date: Thu, 11 Mar 2010 15:29:42 +0000 (+0000) Subject: #4303 BeanItemContainer.addItem(null, Object) did not respect contract X-Git-Tag: 6.7.0.beta1~1948 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=34f26e6711bba490f656000d1042e7ddd91b8f9e;p=vaadin-framework.git #4303 BeanItemContainer.addItem(null, Object) did not respect contract svn changeset:11794/svn branch:6.3 --- diff --git a/src/com/vaadin/data/util/BeanItemContainer.java b/src/com/vaadin/data/util/BeanItemContainer.java index f0d806204f..3e3c4a5538 100644 --- a/src/com/vaadin/data/util/BeanItemContainer.java +++ b/src/com/vaadin/data/util/BeanItemContainer.java @@ -258,7 +258,9 @@ public class BeanItemContainer implements Indexed, Sortable, Filterable, public BeanItem addItemAfter(Object previousItemId, Object newItemId) throws UnsupportedOperationException { // only add if the previous item is visible - if (containsId(previousItemId)) { + if (previousItemId == null) { + return addItemAtInternalIndex(0, newItemId); + } else if (containsId(previousItemId)) { return addItemAtInternalIndex(allItems.indexOf(previousItemId) + 1, newItemId); } else {