From: Thomas Müller <thomas.mueller@tmit.eu>
Date: Fri, 5 Jul 2013 11:45:21 +0000 (+0200)
Subject: proper fix for getting the shared item if no user is logged in
X-Git-Tag: v6.0.0alpha2~500^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=352c1415be55ae5797685d2ea22fcd07cdfbf4ec;p=nextcloud-server.git

proper fix for getting the shared item if no user is logged in
---

diff --git a/apps/files/ajax/upload.php b/apps/files/ajax/upload.php
index 733ed95974f..54604d10563 100644
--- a/apps/files/ajax/upload.php
+++ b/apps/files/ajax/upload.php
@@ -26,15 +26,18 @@ if (empty($_POST['dirToken'])) {
 	if (!($linkItem['permissions'] & OCP\PERMISSION_CREATE)) {
 		OCP\JSON::checkLoggedIn();
 	} else {
+		// Setup FS with owner
+		OC_Util::tearDownFS();
+		OC_Util::setupFS($linkItem['uid_owner']);
+
 		// translate linkItem to the real folder name on the file system
-		$sharedItem = OCP\Share::getItemShared($linkItem['item_type'], $linkItem['item_source']);
+		$sharedItem = OCP\Share::getSharedItem($linkItem['item_type'], $linkItem['item_source'], $linkItem['uid_owner']);
 		if (!$sharedItem || empty($sharedItem) || $sharedItem === false) {
 			OCP\JSON::error(array('data' => array_merge(array('message' => $l->t('Unable to set upload directory.')))));
 			die();
 		}
 
 		// The token defines the target directory (security reasons)
-		$sharedItem = array_pop($sharedItem);
 		$dir = sprintf(
 			"/%s/%s",
 			$sharedItem['path'],
@@ -45,8 +48,6 @@ if (empty($_POST['dirToken'])) {
 			OCP\JSON::error(array('data' => array_merge(array('message' => $l->t('Unable to set upload directory.')))));
 			die();
 		}
-		// Setup FS with owner
-		OC_Util::setupFS($linkItem['uid_owner']);
 	}
 }
 
diff --git a/lib/public/share.php b/lib/public/share.php
index de7025d7b15..28878c2c868 100644
--- a/lib/public/share.php
+++ b/lib/public/share.php
@@ -312,11 +312,22 @@ class Share {
 	* @return Return depends on format
 	*/
 	public static function getItemShared($itemType, $itemSource, $format = self::FORMAT_NONE,
-		$parameters = null, $includeCollections = false) {
+	                                     $parameters = null, $includeCollections = false) {
 		return self::getItems($itemType, $itemSource, null, null, \OC_User::getUser(), $format,
 			$parameters, -1, $includeCollections);
 	}
 
+	/**
+	 * @param $itemType
+	 * @param $itemSource
+	 * @param $uid_owner
+	 * @return mixed
+	 */
+	public static function getSharedItem($itemType, $itemSource, $uid_owner) {
+		return self::getItems($itemType, $itemSource, null, null, $uid_owner, self::FORMAT_NONE,
+			null, 1, false);
+	}
+
 	/**
 	* Get all users an item is shared with
 	* @param string Item type