From: Scott González Date: Wed, 11 May 2011 12:40:16 +0000 (-0400) Subject: Autocomplete: Use appropriate methods for getting scroll values for .prop()/.attr... X-Git-Tag: 1.8.13~8 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=36110e07d471ee0d59d9ac5b5077deda7005d155;p=jquery-ui.git Autocomplete: Use appropriate methods for getting scroll values for .prop()/.attr() compat. Fixes #7354 - Autocomplete: Scrollable results don't visually update with jQuery 1.6. --- diff --git a/ui/jquery.ui.autocomplete.js b/ui/jquery.ui.autocomplete.js index dfe3fa3f3..62fb782df 100644 --- a/ui/jquery.ui.autocomplete.js +++ b/ui/jquery.ui.autocomplete.js @@ -490,12 +490,12 @@ $.widget("ui.menu", { this.deactivate(); if (this.hasScroll()) { var offset = item.offset().top - this.element.offset().top, - scroll = this.element.attr("scrollTop"), + scroll = this.element.scrollTop(), elementHeight = this.element.height(); if (offset < 0) { - this.element.attr("scrollTop", scroll + offset); + this.element.scrollTop( scroll + offset); } else if (offset >= elementHeight) { - this.element.attr("scrollTop", scroll + offset - elementHeight + item.height()); + this.element.scrollTop( scroll + offset - elementHeight + item.height()); } } this.active = item.eq(0) @@ -601,7 +601,7 @@ $.widget("ui.menu", { }, hasScroll: function() { - return this.element.height() < this.element.attr("scrollHeight"); + return this.element.height() < this.element[ $.fn.prop ? "prop" : "attr" ]("scrollHeight"); }, select: function( event ) {