From: Matti Tahvonen <matti.tahvonen@itmill.com>
Date: Thu, 29 Nov 2007 07:07:45 +0000 (+0000)
Subject: Button fixes (icon, description, error toggling)
X-Git-Tag: 6.7.0.beta1~5401
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=38b6fa91ebcb6ba5fde4ef34a7d9bdfe539973b3;p=vaadin-framework.git

Button fixes (icon, description, error toggling)

svn changeset:3028/svn branch:trunk
---

diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/IButton.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/IButton.java
index ce230247e6..74b211bb0b 100644
--- a/src/com/itmill/toolkit/terminal/gwt/client/ui/IButton.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/IButton.java
@@ -79,7 +79,8 @@ public class IButton extends Button implements Paintable {
             errorMessage.updateFromUIDL(errorUidl);
 
         } else if (errorIndicatorElement != null) {
-            DOM.setStyleAttribute(errorIndicatorElement, "display", "none");
+            DOM.removeChild(getElement(), errorIndicatorElement);
+            errorIndicatorElement = null;
         }
 
         if (uidl.hasAttribute("icon")) {
@@ -88,11 +89,18 @@ public class IButton extends Button implements Paintable {
                 DOM.insertChild(getElement(), icon.getElement(), 0);
             }
             icon.setUri(uidl.getStringAttribute("icon"));
+        } else {
+            if (icon != null) {
+                DOM.removeChild(getElement(), icon.getElement());
+                icon = null;
+            }
         }
 
         // handle description
         if (uidl.hasAttribute("description")) {
             setTitle(uidl.getStringAttribute("description"));
+        } else {
+            setTitle(null);
         }
 
     }