From: David Gageot <david@gageot.net>
Date: Fri, 27 Apr 2012 15:12:51 +0000 (+0200)
Subject: Code cleaning : Possible null values
X-Git-Tag: 3.1~321
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=39bf78fdc9455bb630d3ba5ce8a090a125e4682e;p=sonarqube.git

Code cleaning : Possible null values
---

diff --git a/sonar-core/src/test/java/org/sonar/core/resource/ResourceIndexerDaoTest.java b/sonar-core/src/test/java/org/sonar/core/resource/ResourceIndexerDaoTest.java
index 49ab76cb84c..399c7fa69bc 100644
--- a/sonar-core/src/test/java/org/sonar/core/resource/ResourceIndexerDaoTest.java
+++ b/sonar-core/src/test/java/org/sonar/core/resource/ResourceIndexerDaoTest.java
@@ -101,7 +101,9 @@ public class ResourceIndexerDaoTest extends DaoTestCase {
       rs.next();
       assertThat(rs.getInt(1), greaterThan(0));
     } finally {
-      rs.close();
+      if (null != rs) {
+        rs.close();
+      }
       connection.close();
     }
   }
diff --git a/sonar-server/src/main/java/org/sonar/server/charts/ChartsServlet.java b/sonar-server/src/main/java/org/sonar/server/charts/ChartsServlet.java
index 59a508012b5..c56109e8940 100644
--- a/sonar-server/src/main/java/org/sonar/server/charts/ChartsServlet.java
+++ b/sonar-server/src/main/java/org/sonar/server/charts/ChartsServlet.java
@@ -153,8 +153,9 @@ public class ChartsServlet extends HttpServlet {
       }
 
     } catch (Exception e) {
-      LOG.error("Generating chart " + chart.getClass().getName(), e);
-
+      if (chart != null) {
+        LOG.error("Generating chart " + chart.getClass().getName(), e);
+      }
     } finally {
       IOUtils.closeQuietly(out);
     }
diff --git a/sonar-server/src/main/java/org/sonar/server/charts/deprecated/BarChart.java b/sonar-server/src/main/java/org/sonar/server/charts/deprecated/BarChart.java
index 32e9821ecb9..d628e86f283 100644
--- a/sonar-server/src/main/java/org/sonar/server/charts/deprecated/BarChart.java
+++ b/sonar-server/src/main/java/org/sonar/server/charts/deprecated/BarChart.java
@@ -168,9 +168,8 @@ public class BarChart extends BaseChartWeb implements DeprecatedChart {
 
       // Categories
       String categoriesParam = params.get(BaseChartWeb.CHART_PARAM_CATEGORIES);
-      boolean categoriesPresent = categoriesParam != null && categoriesParam.length() > 0;
       String[] categoriesSplit;
-      if (categoriesPresent) {
+      if (categoriesParam != null && categoriesParam.length() > 0) {
         categoriesSplit = categoriesParam.split(",");
       } else {
         categoriesSplit = new String[1];
@@ -179,9 +178,8 @@ public class BarChart extends BaseChartWeb implements DeprecatedChart {
 
       // Series
       String seriesParam = params.get(BaseChartWeb.CHART_PARAM_SERIES);
-      boolean seriesPresent = seriesParam != null && seriesParam.length() > 0;
       String[] seriesSplit = null;
-      if (seriesPresent) {
+      if (seriesParam != null && seriesParam.length() > 0) {
         seriesSplit = seriesParam.split(",");
       } else {
         seriesSplit = new String[nbValues];
diff --git a/sonar-server/src/main/java/org/sonar/server/charts/deprecated/CustomBarChart.java b/sonar-server/src/main/java/org/sonar/server/charts/deprecated/CustomBarChart.java
index db5b3d8c168..e61f82fe9b7 100644
--- a/sonar-server/src/main/java/org/sonar/server/charts/deprecated/CustomBarChart.java
+++ b/sonar-server/src/main/java/org/sonar/server/charts/deprecated/CustomBarChart.java
@@ -108,9 +108,8 @@ public class CustomBarChart extends BarChart {
 
       // Categories
       String categoriesParam = params.get(CHART_PARAM_CATEGORIES);
-      boolean categoriesPresent = categoriesParam != null && categoriesParam.length() > 0;
       String[] categoriesSplit = null;
-      if (categoriesPresent) {
+      if (categoriesParam != null && categoriesParam.length() > 0) {
         categoriesSplit = categoriesParam.split(",");
       } else {
         categoriesSplit = new String[nbValues];