From: Leif Åstrand <leif@vaadin.com>
Date: Fri, 10 Aug 2012 08:30:24 +0000 (+0300)
Subject: Allow detaching Extension once (#9282)
X-Git-Tag: 7.0.0.beta1~230^2~6
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=3c1e9fb02c8fc376c16f9069a58f17227f7f58de;p=vaadin-framework.git

Allow detaching Extension once (#9282)
---

diff --git a/src/com/vaadin/terminal/gwt/client/extensions/AbstractExtensionConnector.java b/src/com/vaadin/terminal/gwt/client/extensions/AbstractExtensionConnector.java
index bcefcf05cb..408f03f6cb 100644
--- a/src/com/vaadin/terminal/gwt/client/extensions/AbstractExtensionConnector.java
+++ b/src/com/vaadin/terminal/gwt/client/extensions/AbstractExtensionConnector.java
@@ -8,17 +8,26 @@ import com.vaadin.terminal.gwt.client.ServerConnector;
 import com.vaadin.terminal.gwt.client.ui.AbstractConnector;
 
 public abstract class AbstractExtensionConnector extends AbstractConnector {
+    boolean hasBeenAttached = false;
+
     @Override
     public void setParent(ServerConnector parent) {
         ServerConnector oldParent = getParent();
-        if (oldParent != null && oldParent != parent) {
+        if (oldParent == parent) {
+            // Nothing to do
+            return;
+        }
+        if (hasBeenAttached && parent != null) {
             throw new IllegalStateException(
                     "An extension can not be moved from one parent to another.");
         }
 
         super.setParent(parent);
 
-        extend(parent);
+        if (parent != null) {
+            extend(parent);
+            hasBeenAttached = true;
+        }
     }
 
     protected void extend(ServerConnector target) {