From: Artur Signell <artur.signell@itmill.com>
Date: Wed, 7 Dec 2011 23:49:32 +0000 (+0000)
Subject: #6603 AbstractBeanContainer.addAll does not ensure resolved itemIds are not null
X-Git-Tag: 7.0.0.alpha1~225^2~1^2~4
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=3c2b32e356cb74d972864d78fabe20a36f02a8ee;p=vaadin-framework.git

#6603 AbstractBeanContainer.addAll does not ensure resolved itemIds are not null

svn changeset:22308/svn branch:6.7
---

diff --git a/src/com/vaadin/data/util/AbstractBeanContainer.java b/src/com/vaadin/data/util/AbstractBeanContainer.java
index b1d0b0672b..1b297d6a88 100644
--- a/src/com/vaadin/data/util/AbstractBeanContainer.java
+++ b/src/com/vaadin/data/util/AbstractBeanContainer.java
@@ -637,6 +637,11 @@ public abstract class AbstractBeanContainer<IDTYPE, BEANTYPE> extends
                 continue;
             }
             IDTYPE itemId = resolveBeanId(bean);
+            if (itemId == null) {
+                throw new IllegalArgumentException(
+                        "Resolved identifier for a bean must not be null");
+            }
+
             if (internalAddItemAtEnd(itemId, createBeanItem(bean), false) != null) {
                 modified = true;
             }