From: Christoph Wurst <christoph@winzerhof-wurst.at>
Date: Tue, 30 May 2023 15:48:20 +0000 (+0200)
Subject: chore(app): Do not clear unused cache key
X-Git-Tag: v28.0.0beta1~952^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=3d1acca1f389db89298f5b8445118b75c56c5e7f;p=nextcloud-server.git

chore(app): Do not clear unused cache key

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
---

diff --git a/lib/private/App/AppManager.php b/lib/private/App/AppManager.php
index 9b038b73826..b881d37440e 100644
--- a/lib/private/App/AppManager.php
+++ b/lib/private/App/AppManager.php
@@ -673,8 +673,6 @@ class AppManager implements IAppManager {
 	 * Clear the cached list of apps when enabling/disabling an app
 	 */
 	public function clearAppsCache() {
-		$settingsMemCache = $this->memCacheFactory->createDistributed('settings');
-		$settingsMemCache->clear('listApps');
 		$this->appInfos = [];
 	}
 
diff --git a/tests/lib/App/AppManagerTest.php b/tests/lib/App/AppManagerTest.php
index 3518ada3314..d597b216041 100644
--- a/tests/lib/App/AppManagerTest.php
+++ b/tests/lib/App/AppManagerTest.php
@@ -133,14 +133,7 @@ class AppManagerTest extends TestCase {
 		);
 	}
 
-	protected function expectClearCache() {
-		$this->cache->expects($this->once())
-			->method('clear')
-			->with('listApps');
-	}
-
 	public function testEnableApp() {
-		$this->expectClearCache();
 		// making sure "files_trashbin" is disabled
 		if ($this->manager->isEnabledForUser('files_trashbin')) {
 			$this->manager->disableApp('files_trashbin');
@@ -151,7 +144,6 @@ class AppManagerTest extends TestCase {
 	}
 
 	public function testDisableApp() {
-		$this->expectClearCache();
 		$this->eventDispatcher->expects($this->once())->method('dispatchTyped')->with(new AppDisableEvent('files_trashbin'));
 		$this->manager->disableApp('files_trashbin');
 		$this->assertEquals('no', $this->appConfig->getValue('files_trashbin', 'enabled', 'no'));
@@ -180,7 +172,6 @@ class AppManagerTest extends TestCase {
 			->willReturn('group2');
 
 		$groups = [$group1, $group2];
-		$this->expectClearCache();
 
 		/** @var AppManager|MockObject $manager */
 		$manager = $this->getMockBuilder(AppManager::class)
@@ -229,7 +220,6 @@ class AppManagerTest extends TestCase {
 			->willReturn('group2');
 
 		$groups = [$group1, $group2];
-		$this->expectClearCache();
 
 		/** @var AppManager|MockObject $manager */
 		$manager = $this->getMockBuilder(AppManager::class)