From: Rick Waldron Date: Fri, 22 Apr 2011 04:02:08 +0000 (-0400) Subject: Landing pull request 340. Adds widows, orphans to cssNumber hash; includes tests... X-Git-Tag: 1.6rc1~9^2 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=3d9445e3fce84448b4b569a1a6f1aa454a898265;p=jquery.git Landing pull request 340. Adds widows, orphans to cssNumber hash; includes tests. Fixes #8936. More Details: - https://github.com/jquery/jquery/pull/340 - http://bugs.jquery.com/ticket/8936 --- diff --git a/src/css.js b/src/css.js index c5c01ecac..318cd5979 100644 --- a/src/css.js +++ b/src/css.js @@ -59,7 +59,9 @@ jQuery.extend({ "fontWeight": true, "opacity": true, "zoom": true, - "lineHeight": true + "lineHeight": true, + "widows": true, + "orphans": true }, // Add in properties whose names you wish to fix before diff --git a/test/unit/css.js b/test/unit/css.js index 60e8744c1..a34f54a06 100644 --- a/test/unit/css.js +++ b/test/unit/css.js @@ -45,9 +45,9 @@ test("css(String|Hash)", function() { equals( jQuery("#floatTest").css("float"), "right", "Modified CSS float using \"float\": Assert float is right"); jQuery("#floatTest").css({"font-size": "30px"}); equals( jQuery("#floatTest").css("font-size"), "30px", "Modified CSS font-size: Assert font-size is 30px"); - jQuery.each("0,0.25,0.5,0.75,1".split(","), function(i, n) { jQuery("#foo").css({opacity: n}); + equals( jQuery("#foo").css("opacity"), parseFloat(n), "Assert opacity is " + parseFloat(n) + " as a String" ); jQuery("#foo").css({opacity: parseFloat(n)}); equals( jQuery("#foo").css("opacity"), parseFloat(n), "Assert opacity is " + parseFloat(n) + " as a Number" ); @@ -394,3 +394,27 @@ test("jQuery.cssProps behavior, (bug #8402)", function() { // cleanup jQuery.cssProps jQuery.cssProps.top = undefined; }); + +test("widows & orphans #8936", function () { + expect(4); + + var $p = jQuery("

").appendTo("#main").end(); + + $p.css({ + widows: 0, + orphans: 0 + }); + + equal( $p.css("widows"), 0, "widows correctly start with value 0"); + equal( $p.css("orphans"), 0, "orphans correctly start with value 0"); + + $p.css({ + widows: 3, + orphans: 3 + }); + + equal( $p.css("widows"), 3, "widows correctly set to 3"); + equal( $p.css("orphans"), 3, "orphans correctly set to 3"); + + $p.remove(); +});