From: Lunny Xiao <xiaolunwen@gmail.com>
Date: Tue, 24 Sep 2024 01:30:05 +0000 (+0800)
Subject: Fix panic when cloning with wrong ssh format. (#32076)
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=3f2d8f873035b614b4cdb447d8e16f5af82cefe8;p=gitea.git

Fix panic when cloning with wrong ssh format. (#32076)
---

diff --git a/cmd/serv.go b/cmd/serv.go
index 2bfd111061..f74a8fd3d0 100644
--- a/cmd/serv.go
+++ b/cmd/serv.go
@@ -143,6 +143,12 @@ func runServ(c *cli.Context) error {
 		return nil
 	}
 
+	defer func() {
+		if err := recover(); err != nil {
+			_ = fail(ctx, "Internal Server Error", "Panic: %v\n%s", err, log.Stack(2))
+		}
+	}()
+
 	keys := strings.Split(c.Args().First(), "-")
 	if len(keys) != 2 || keys[0] != "key" {
 		return fail(ctx, "Key ID format error", "Invalid key argument: %s", c.Args().First())
@@ -189,10 +195,7 @@ func runServ(c *cli.Context) error {
 	}
 
 	verb := words[0]
-	repoPath := words[1]
-	if repoPath[0] == '/' {
-		repoPath = repoPath[1:]
-	}
+	repoPath := strings.TrimPrefix(words[1], "/")
 
 	var lfsVerb string
 	if verb == lfsAuthenticateVerb {