From: Jeremy Davis <jeremy.davis@sonarsource.com>
Date: Mon, 4 Dec 2023 17:05:23 +0000 (+0100)
Subject: SONAR-21067 Fixes from validation
X-Git-Tag: 10.4.0.87286~366
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=4540cf74fce38f6a0f0fc9fea1bec7be78aa7b1b;p=sonarqube.git

SONAR-21067 Fixes from validation
---

diff --git a/server/sonar-web/src/main/js/apps/settings/components/inputs/PropertySetInput.tsx b/server/sonar-web/src/main/js/apps/settings/components/inputs/PropertySetInput.tsx
index 8c9bd9d9643..5dbaccb068d 100644
--- a/server/sonar-web/src/main/js/apps/settings/components/inputs/PropertySetInput.tsx
+++ b/server/sonar-web/src/main/js/apps/settings/components/inputs/PropertySetInput.tsx
@@ -77,25 +77,27 @@ export default class PropertySetInput extends React.PureComponent<DefaultSpecial
                   name={getUniqueName(definition, field.key)}
                   onChange={(value) => this.handleInputChange(index, field.key, value)}
                   setting={newSetting}
-                  size="auto"
+                  size="full"
                   value={fieldValues[field.key]}
                 />
               </ContentCell>
             );
           })}
         <ActionCell className="sw-border-0">
-          {!isLast && (
-            <DestructiveIcon
-              Icon={TrashIcon}
-              aria-label={translateWithParameters(
-                'settings.definitions.delete_fields',
-                getPropertyName(setting.definition),
-                index,
-              )}
-              className="js-remove-value"
-              onClick={() => this.handleDeleteValue(index)}
-            />
-          )}
+          <div className="sw-w-9">
+            {!isLast && (
+              <DestructiveIcon
+                Icon={TrashIcon}
+                aria-label={translateWithParameters(
+                  'settings.definitions.delete_fields',
+                  getPropertyName(setting.definition),
+                  index,
+                )}
+                className="js-remove-value"
+                onClick={() => this.handleDeleteValue(index)}
+              />
+            )}
+          </div>
         </ActionCell>
       </TableRow>
     );
@@ -106,7 +108,7 @@ export default class PropertySetInput extends React.PureComponent<DefaultSpecial
     const displayedValue = [...this.ensureValue(), ...getEmptyValue(definition)];
 
     const columnWidths = (isCategoryDefinition(definition) ? definition.fields : [])
-      .map(() => 'auto')
+      .map(() => '50%')
       .concat('1px');
 
     return (
diff --git a/server/sonar-web/src/main/js/apps/settings/components/pullRequestDecorationBinding/AlmSpecificForm.tsx b/server/sonar-web/src/main/js/apps/settings/components/pullRequestDecorationBinding/AlmSpecificForm.tsx
index de956ccca47..59d2ca83c05 100644
--- a/server/sonar-web/src/main/js/apps/settings/components/pullRequestDecorationBinding/AlmSpecificForm.tsx
+++ b/server/sonar-web/src/main/js/apps/settings/components/pullRequestDecorationBinding/AlmSpecificForm.tsx
@@ -23,7 +23,7 @@ import { FormattedMessage } from 'react-intl';
 import withAvailableFeatures, {
   WithAvailableFeaturesProps,
 } from '../../../../app/components/available-features/withAvailableFeatures';
-import DocLink from '../../../../components/common/DocLink';
+import DocumentationLink from '../../../../components/common/DocumentationLink';
 import MandatoryFieldMarker from '../../../../components/ui/MandatoryFieldMarker';
 import { ALM_DOCUMENTATION_PATHS } from '../../../../helpers/constants';
 import { translate } from '../../../../helpers/l10n';
@@ -297,7 +297,9 @@ export function AlmSpecificForm(props: AlmSpecificFormProps) {
           help: true,
           helpParams: {
             doc_link: (
-              <DocLink to={ALM_DOCUMENTATION_PATHS[alm]}>{translate('learn_more')}</DocLink>
+              <DocumentationLink to={ALM_DOCUMENTATION_PATHS[alm]}>
+                {translate('learn_more')}
+              </DocumentationLink>
             ),
           },
           id: 'monorepo',