From: James Ahlborn <jtahlborn@yahoo.com>
Date: Mon, 12 Jun 2006 19:22:46 +0000 (+0000)
Subject: add break statement, although differences in getLongBinaryValue and getLongStringValu... 
X-Git-Tag: rel_1_1_4~9
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=472e8257431c0293de7145ae1574076fb652863f;p=jackcess.git

add break statement, although differences in getLongBinaryValue and getLongStringValue seem a little suspicious


git-svn-id: https://svn.code.sf.net/p/jackcess/code/jackcess/trunk@49 f203690c-595d-4dc9-a70b-905162fa7fd2
---

diff --git a/src/java/com/healthmarketscience/jackcess/Column.java b/src/java/com/healthmarketscience/jackcess/Column.java
index 822fb2b..aa0b18e 100644
--- a/src/java/com/healthmarketscience/jackcess/Column.java
+++ b/src/java/com/healthmarketscience/jackcess/Column.java
@@ -340,7 +340,6 @@ public class Column implements Comparable<Column> {
    * @param lvalDefinition Column value that points to an LVAL record
    * @return The LVAL data
    */
-  @SuppressWarnings("fallthrough")
   private byte[] getLongBinaryValue(byte[] lvalDefinition) throws IOException {
     ByteBuffer def = ByteBuffer.wrap(lvalDefinition);
     def.order(ByteOrder.LITTLE_ENDIAN);
@@ -368,8 +367,10 @@ public class Column implements Comparable<Column> {
         lvalPage.get(rtn);
         break;
       case LONG_VALUE_TYPE_THIS_PAGE:
+        // FIXME, is this correct?
         def.getLong();  //Skip over lval_dp and unknown
         def.get(rtn);
+        break;
       case LONG_VALUE_TYPE_OTHER_PAGES:
         //XXX
         return null;
@@ -383,7 +384,6 @@ public class Column implements Comparable<Column> {
    * @param lvalDefinition Column value that points to an LVAL record
    * @return The LVAL data
    */
-  @SuppressWarnings("fallthrough")
   private String getLongStringValue(byte[] lvalDefinition) throws IOException {
     ByteBuffer def = ByteBuffer.wrap(lvalDefinition);
     def.order(ByteOrder.LITTLE_ENDIAN);