From: ruado1987 <ruado1987@gmail.com>
Date: Sun, 3 Mar 2013 15:51:04 +0000 (+0800)
Subject: Fix #13514: Set selectedIndex to -1 when non-matching value is set on a select. Close... 
X-Git-Tag: 1.10.0-beta1~58
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=48d71d0c3e53d1bb1688fc6c0593b008ced3403b;p=jquery.git

Fix #13514: Set selectedIndex to -1 when non-matching value is set on a select. Close gh-1191.
---

diff --git a/src/attributes.js b/src/attributes.js
index 6902244ed..9a5276966 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -275,13 +275,20 @@ jQuery.extend({
 			},
 
 			set: function( elem, value ) {
-				var values = jQuery.makeArray( value );
-
-				jQuery(elem).find("option").each(function() {
-					this.selected = jQuery.inArray( jQuery(this).val(), values ) >= 0;
-				});
-
-				if ( !values.length ) {
+				var optionSet, option,
+					options = elem.options,
+					values = jQuery.makeArray( value ),
+					i = options.length;
+				
+				while ( i-- ) {
+					option = options[ i ];
+					if ( (option.selected = jQuery.inArray( jQuery(option).val(), values ) >= 0) ) {
+						optionSet = true;
+					}
+				}
+				
+				// force browsers to behave consistently when non-matching value is set
+				if ( !optionSet ) {
 					elem.selectedIndex = -1;
 				}
 				return values;
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index ccd1f4a99..f0ca137e6 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -850,6 +850,22 @@ test( "val()", function() {
 	equal( jQuery("<option/>").val("test").attr("value"), "test", "Setting value sets the value attribute" );
 });
 
+test("val() with non-matching values on dropdown list", function() {
+	expect( 3 );
+	
+	jQuery("#select5").val( "" );
+	equal( jQuery("#select5").val(), null, "Non-matching set on select-one" );
+	
+	var select6 = jQuery("<select multiple id=\"select6\"><option value=\"1\">A</option><option value=\"2\">B</option></select>").appendTo("#form");
+	jQuery(select6).val( "nothing" );
+	equal( jQuery(select6).val(), null, "Non-matching set (single value) on select-multiple" );
+	
+	jQuery(select6).val( ["nothing1", "nothing2"] );
+	equal( jQuery(select6).val(), null, "Non-matching set (array of values) on select-multiple" );
+	
+	select6.remove();
+});
+
 if ( "value" in document.createElement("meter") &&
 			"value" in document.createElement("progress") ) {