From: Evgeny Mandrikov <mandrikov@gmail.com>
Date: Fri, 28 Sep 2012 06:46:40 +0000 (+0400)
Subject: Fix some quality flaws
X-Git-Tag: 3.3~182
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=4939a71b7d8a97e2bda14649c8381e3a983b0f25;p=sonarqube.git

Fix some quality flaws
---

diff --git a/sonar-channel/src/main/java/org/sonar/channel/ChannelException.java b/sonar-channel/src/main/java/org/sonar/channel/ChannelException.java
index af378f6a7bf..e38b69e600f 100644
--- a/sonar-channel/src/main/java/org/sonar/channel/ChannelException.java
+++ b/sonar-channel/src/main/java/org/sonar/channel/ChannelException.java
@@ -21,11 +21,16 @@ package org.sonar.channel;
 
 public class ChannelException extends RuntimeException {
 
-  public ChannelException(String message, Exception e) {
-    super(message, e);
+  public ChannelException(String message, Exception cause) {
+    super(message, cause);
   }
 
   public ChannelException(String message) {
     super(message);
   }
+
+  public ChannelException(String message, Throwable cause) {
+    super(message, cause);
+  }
+
 }
diff --git a/sonar-channel/src/main/java/org/sonar/channel/CodeReader.java b/sonar-channel/src/main/java/org/sonar/channel/CodeReader.java
index 4ca2328186e..4a615b6fc03 100644
--- a/sonar-channel/src/main/java/org/sonar/channel/CodeReader.java
+++ b/sonar-channel/src/main/java/org/sonar/channel/CodeReader.java
@@ -194,7 +194,7 @@ public class CodeReader extends CodeBuffer {
       throw new ChannelException("Unable to apply regular expression '" + matcher.pattern().pattern()
           + "' at line " + getCursor().getLine() + " and column " + getCursor().getColumn()
           + ", because it led to a stack overflow error."
-          + " This error may be due to an inefficient use of alternations - see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5050507");
+          + " This error may be due to an inefficient use of alternations - see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5050507", e);
     } catch (IndexOutOfBoundsException e) {
       return -1;
     } catch (IOException e) {
diff --git a/sonar-channel/src/test/java/org/sonar/channel/CodeReaderTest.java b/sonar-channel/src/test/java/org/sonar/channel/CodeReaderTest.java
index d52ae92b2aa..5ae280db679 100644
--- a/sonar-channel/src/test/java/org/sonar/channel/CodeReaderTest.java
+++ b/sonar-channel/src/test/java/org/sonar/channel/CodeReaderTest.java
@@ -101,7 +101,7 @@ public class CodeReaderTest {
   }
 
   @Test
-  public void test() {
+  public void testStackOverflowError() {
     StringBuilder sb = new StringBuilder();
     sb.append("\n");
     for (int i = 0; i < 10000; i++) {