From: Go MAEDA <maeda@farend.jp>
Date: Fri, 7 May 2021 04:45:08 +0000 (+0000)
Subject: Duplicate entries in issue filter values (#35201).
X-Git-Tag: 5.0.0~404
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=49e323ae7af2998fc2785319643a9ac5bc93c425;p=redmine.git

Duplicate entries in issue filter values (#35201).

Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@20990 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/models/query.rb b/app/models/query.rb
index e8de4aa6d..fad3930aa 100644
--- a/app/models/query.rb
+++ b/app/models/query.rb
@@ -531,7 +531,7 @@ class Query < ActiveRecord::Base
       if has_filter?(field) || !filter.remote
         options[:values] = filter.values
         if options[:values] && values_for(field)
-          missing = Array(values_for(field)).select(&:present?) - options[:values].map(&:last)
+          missing = Array(values_for(field)).select(&:present?) - options[:values].map{|v| v[1]}
           if missing.any? && respond_to?(method = "find_#{field}_filter_values")
             options[:values] += send(method, missing)
           end
diff --git a/test/unit/query_test.rb b/test/unit/query_test.rb
index 118cb3dc1..d2159c84b 100644
--- a/test/unit/query_test.rb
+++ b/test/unit/query_test.rb
@@ -1560,6 +1560,19 @@ class QueryTest < ActiveSupport::TestCase
     end
   end
 
+  def test_available_filters_as_json_should_not_include_duplicate_assigned_to_id_values
+    set_language_if_valid 'en'
+    user = User.find_by_login 'dlopper'
+    with_current_user User.find(1) do
+      q = IssueQuery.new
+      q.filters = {"assigned_to_id" => {:operator => '=', :values => user.id.to_s}}
+
+      filters = q.available_filters_as_json
+      assert_not_include [user.name, user.id.to_s], filters['assigned_to_id']['values']
+      assert_include [user.name, user.id.to_s, 'active'], filters['assigned_to_id']['values']
+    end
+  end
+
   def test_available_filters_as_json_should_include_missing_author_id_values
     user = User.generate!
     with_current_user User.find(1) do