From: Javen O'Neal <onealj@apache.org>
Date: Sun, 31 Jan 2016 12:14:55 +0000 (+0000)
Subject: fix O(n^2) runtime unnecessarily recreating an array inside a for-loop
X-Git-Tag: REL_3_14_FINAL~53
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=4c82305d3d8394c94249812b02080a115780436a;p=poi.git

fix O(n^2) runtime unnecessarily recreating an array inside a for-loop

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/java/org/apache/poi/hssf/record/EscherAggregate.java b/src/java/org/apache/poi/hssf/record/EscherAggregate.java
index 21c4db4542..36215b79c3 100644
--- a/src/java/org/apache/poi/hssf/record/EscherAggregate.java
+++ b/src/java/org/apache/poi/hssf/record/EscherAggregate.java
@@ -301,7 +301,7 @@ public final class EscherAggregate extends AbstractEscherHolderRecord {
     /**
      * list of "tail" records that need to be serialized after all drawing group records
      */
-    private Map<Integer, NoteRecord> tailRec = new LinkedHashMap<Integer, NoteRecord>();
+    private final Map<Integer, NoteRecord> tailRec = new LinkedHashMap<Integer, NoteRecord>();
 
     /**
      * create new EscherAggregate
@@ -522,8 +522,8 @@ public final class EscherAggregate extends AbstractEscherHolderRecord {
             pos += writeDataIntoDrawingRecord(drawingData, writtenEscherBytes, pos, data, i);
         }
 
-        for (i = 0; i < tailRec.size(); i++) {
-            Record rec = (Record) tailRec.values().toArray()[i];
+        for (NoteRecord noteRecord : tailRec.values()) {
+            Record rec = (Record) noteRecord;
             pos += rec.serialize(pos, data);
         }
         int bytesWritten = pos - offset;