From: Daniel Husar Date: Fri, 7 Feb 2014 10:30:13 +0000 (+0000) Subject: Core: Simplify and speed up .each X-Git-Tag: 3.0.0-alpha1+compat~183 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=4cc4e54298bca84d0a0b2f2eb1ee97ca619485b1;p=jquery.git Core: Simplify and speed up .each Closes gh-1510 (cherry picked from commit eeda11cdd6a69ec2ef4e9c1ed12b82a79910fda5) --- diff --git a/src/core.js b/src/core.js index 5251dc639..3a693b4f5 100644 --- a/src/core.js +++ b/src/core.js @@ -301,25 +301,20 @@ jQuery.extend({ // args is for internal usage only each: function( obj, callback, args ) { - var value, - i = 0, + var i = 0, length = obj.length, isArray = isArraylike( obj ); if ( args ) { if ( isArray ) { for ( ; i < length; i++ ) { - value = callback.apply( obj[ i ], args ); - - if ( value === false ) { + if ( callback.apply( obj[ i ], args ) === false ) { break; } } } else { for ( i in obj ) { - value = callback.apply( obj[ i ], args ); - - if ( value === false ) { + if ( callback.apply( obj[ i ], args ) === false ) { break; } } @@ -329,17 +324,13 @@ jQuery.extend({ } else { if ( isArray ) { for ( ; i < length; i++ ) { - value = callback.call( obj[ i ], i, obj[ i ] ); - - if ( value === false ) { + if ( callback.call( obj[ i ], i, obj[ i ] ) === false ) { break; } } } else { for ( i in obj ) { - value = callback.call( obj[ i ], i, obj[ i ] ); - - if ( value === false ) { + if ( callback.call( obj[ i ], i, obj[ i ] ) === false ) { break; } }