From: Scott González <scott.gonzalez@gmail.com>
Date: Sat, 6 Aug 2011 17:27:42 +0000 (-0400)
Subject: Spinner: Don't stop propgation of mousedown. Added TODOs.
X-Git-Tag: 1.9m6~68
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=4d2ac1abca64ec19407f4a8217388223aea9cca4;p=jquery-ui.git

Spinner: Don't stop propgation of mousedown. Added TODOs.
---

diff --git a/ui/jquery.ui.spinner.js b/ui/jquery.ui.spinner.js
index 1b55d8374..a8f3a4fe9 100644
--- a/ui/jquery.ui.spinner.js
+++ b/ui/jquery.ui.spinner.js
@@ -103,14 +103,15 @@ $.widget( "ui.spinner", {
 		this._bind( this.buttons, {
 			mousedown: function( event ) {
 				if ( this._start( event ) === false ) {
-					// TODO: do we really want to stop propagation?
-					return false;
+					return;
 				}
+
 				this._repeat( null, $( event.currentTarget ).hasClass( "ui-spinner-up" ) ? 1 : -1, event );
 			},
 			mouseup: function( event ) {
 				if ( this.spinning ) {
 					this._stop( event );
+					// TODO: don't trigger change until the field is blurred
 					this._change( event );
 				}
 			},
@@ -125,7 +126,9 @@ $.widget( "ui.spinner", {
 				}
 				this._repeat( null, $( event.currentTarget ).hasClass( "ui-spinner-up" ) ? 1 : -1, event );
 			},
-			// TODO: we shouldn't trigger any events until mouseup
+			// TODO: do we really want to consider this a stop?
+			// shouldn't we just stop the repeater and wait until mouseup before
+			// we trigger the stop event?
 			mouseleave: function() {
 				if ( this.spinning ) {
 					this._stop( event );
@@ -183,6 +186,7 @@ $.widget( "ui.spinner", {
 				this.timeout = setTimeout(function() {
 					if ( this.spinning ) {
 						this._stop( event );
+						// TODO: don't trigger change until the field is blurred
 						this._change( event );
 					}
 				}, 100 );