From: Henri Sara <hesara@vaadin.com>
Date: Thu, 31 Aug 2017 06:08:10 +0000 (+0300)
Subject: Make BaseThemeTest more stable on IE11
X-Git-Tag: 8.2.0.alpha1~18
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=514f3a88a24dd69da2fd3a8ce305f21f50b91919;p=vaadin-framework.git

Make BaseThemeTest more stable on IE11

Try to make the test more stable by using a different way of
detecting the presence of a notification. This approach is used e.g.
in GridComponentsTest.
---

diff --git a/uitest/src/test/java/com/vaadin/tests/components/uitest/ThemeTest.java b/uitest/src/test/java/com/vaadin/tests/components/uitest/ThemeTest.java
index f6f88baafe..39ee947fb6 100644
--- a/uitest/src/test/java/com/vaadin/tests/components/uitest/ThemeTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/components/uitest/ThemeTest.java
@@ -129,7 +129,8 @@ public abstract class ThemeTest extends MultiBrowserTest {
     private void testNotification(int id, String identifier)
             throws IOException {
         $(ButtonElement.class).id("notifButt" + id).click();
-        waitForElementPresent(By.className("v-Notification"));
+        // For some reason, this seems to be more reliable on IE11
+        waitUntil(driver -> isElementPresent(NotificationElement.class), 10);
         compareScreen(identifier);
         $(NotificationElement.class).first().close();
     }