From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Tue, 8 Dec 2009 16:06:22 +0000 (+0000)
Subject: Fixed: Subversion#latest_changesets ignores revision argument (#4360).
X-Git-Tag: 0.9.0~128
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=517a87f8c52e121ae213490bacc5810208bf4152;p=redmine.git

Fixed: Subversion#latest_changesets ignores revision argument (#4360).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3134 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/models/repository/subversion.rb b/app/models/repository/subversion.rb
index 86ac5a921..0f9b56746 100644
--- a/app/models/repository/subversion.rb
+++ b/app/models/repository/subversion.rb
@@ -31,7 +31,7 @@ class Repository::Subversion < Repository
   end
 
   def latest_changesets(path, rev, limit=10)
-    revisions = scm.revisions(path, nil, nil, :limit => limit)
+    revisions = scm.revisions(path, rev, nil, :limit => limit)
     revisions ? changesets.find_all_by_revision(revisions.collect(&:identifier), :order => "committed_on DESC", :include => :user) : []
   end
   
diff --git a/test/unit/repository_subversion_test.rb b/test/unit/repository_subversion_test.rb
index f0ad212ca..fb5580c42 100644
--- a/test/unit/repository_subversion_test.rb
+++ b/test/unit/repository_subversion_test.rb
@@ -49,17 +49,21 @@ class RepositorySubversionTest < ActiveSupport::TestCase
       assert_equal 10, @repository.changesets.count
     end
     
-    def test_latest_changesets_with_limit
+    def test_latest_changesets
       @repository.fetch_changesets
+      
+      # with limit
       changesets = @repository.latest_changesets('', nil, 2)
       assert_equal 2, changesets.size
       assert_equal @repository.latest_changesets('', nil).slice(0,2), changesets
-    end
-    
-    def test_latest_changesets_with_path
-      @repository.fetch_changesets
-      changesets = @repository.latest_changesets('subversion_test/folder/helloworld.rb', nil)
-      assert_equal %w(6 3 2), changesets.collect(&:revision)
+      
+      # with path
+      changesets = @repository.latest_changesets('subversion_test/folder', nil)
+      assert_equal ["10", "9", "7", "6", "5", "2"], changesets.collect(&:revision)
+      
+      # with path and revision
+      changesets = @repository.latest_changesets('subversion_test/folder', 8)
+      assert_equal ["7", "6", "5", "2"], changesets.collect(&:revision)
     end
   else
     puts "Subversion test repository NOT FOUND. Skipping unit tests !!!"