From: Grigorii K. Shartsev <me@shgk.me>
Date: Sat, 21 Oct 2023 01:49:01 +0000 (+0200)
Subject: fix(settings): users page html validation
X-Git-Tag: v28.0.0beta1~81^2~2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=5249c3376e70c3ff8dce7f60287b1f8711cc9b86;p=nextcloud-server.git

fix(settings): users page html validation

- Remove non-existing `button-class` from `NcAppNavigationNew`
- Type: use `input-id` instead of `id` on `NcSelect` to be labeled
- Encode uniqueId with user's ID, because user.id may contain space

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
---

diff --git a/apps/settings/src/components/Users/UserRow.vue b/apps/settings/src/components/Users/UserRow.vue
index d62780d2b61..8b39e611044 100644
--- a/apps/settings/src/components/Users/UserRow.vue
+++ b/apps/settings/src/components/Users/UserRow.vue
@@ -150,7 +150,7 @@
 					:for="'subadmins' + uniqueId">
 					{{ t('settings', 'Set user as admin for') }}
 				</label>
-				<NcSelect :id="'subadmins' + uniqueId"
+				<NcSelect :input-id="'subadmins' + uniqueId"
 					:close-on-select="false"
 					:disabled="isLoadingField"
 					:loading="loading.subadmins"
@@ -406,7 +406,7 @@ export default {
 		},
 
 		uniqueId() {
-			return this.user.id + this.rand
+			return encodeURIComponent(this.user.id + this.rand)
 		},
 
 		userGroupsLabels() {
diff --git a/apps/settings/src/views/Users.vue b/apps/settings/src/views/Users.vue
index 13a7d46d256..f6c61998a73 100644
--- a/apps/settings/src/views/Users.vue
+++ b/apps/settings/src/views/Users.vue
@@ -26,7 +26,6 @@
 			<NcAppNavigation>
 				<NcAppNavigationNew button-id="new-user-button"
 					:text="t('settings','New user')"
-					button-class="icon-add"
 					@click="showNewUserMenu"
 					@keyup.enter="showNewUserMenu"
 					@keyup.space="showNewUserMenu">