From: Josh Micich <josh@apache.org>
Date: Sat, 29 Nov 2008 02:07:49 +0000 (+0000)
Subject: Simplified logic in getStyleRecord() (investigating bug 46259)
X-Git-Tag: REL_3_5_BETA5~79
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=545ebccb609f0922d36ea3778fd33e39a3677f71;p=poi.git

Simplified logic in getStyleRecord() (investigating bug 46259)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@721614 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/java/org/apache/poi/hssf/model/Workbook.java b/src/java/org/apache/poi/hssf/model/Workbook.java
index 76854518f8..765dc1afd3 100644
--- a/src/java/org/apache/poi/hssf/model/Workbook.java
+++ b/src/java/org/apache/poi/hssf/model/Workbook.java
@@ -72,6 +72,7 @@ import org.apache.poi.hssf.record.StyleRecord;
 import org.apache.poi.hssf.record.SupBookRecord;
 import org.apache.poi.hssf.record.TabIdRecord;
 import org.apache.poi.hssf.record.UnicodeString;
+import org.apache.poi.hssf.record.UnknownRecord;
 import org.apache.poi.hssf.record.UseSelFSRecord;
 import org.apache.poi.hssf.record.WindowOneRecord;
 import org.apache.poi.hssf.record.WindowProtectRecord;
@@ -824,18 +825,17 @@ public final class Workbook implements Model {
     public StyleRecord getStyleRecord(int xfIndex) {
         // Style records always follow after 
         //  the ExtendedFormat records
-        boolean done = false;
-        for(int i=records.getXfpos(); i<records.size() &&
-                !done; i++) {
+        for(int i=records.getXfpos(); i<records.size(); i++) {
             Record r = records.get(i);
             if(r instanceof ExtendedFormatRecord) {
-            } else if(r instanceof StyleRecord) {
-                StyleRecord sr = (StyleRecord)r;
-                if(sr.getXFIndex() == xfIndex) {
-                    return sr;
-                }
-            } else {
-                done = true;
+                continue;
+            }
+            if(!(r instanceof StyleRecord)) {
+                return null;
+            }
+            StyleRecord sr = (StyleRecord)r;
+            if(sr.getXFIndex() == xfIndex) {
+                return sr;
             }
         }
         return null;