From: Corey Frang <gnarf@gnarf.net>
Date: Wed, 24 Apr 2013 20:07:15 +0000 (-0400)
Subject: Fixes #13815: Ensure each element has its own private data object - Tests by @rwldrn
X-Git-Tag: 2.0.1~34
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=55e319aa52eb828a3a4c2298aa75b6d15cfa06f8;p=jquery.git

Fixes #13815: Ensure each element has its own private data object - Tests by @rwldrn
---

diff --git a/src/data.js b/src/data.js
index 0fd35033a..344dae25f 100644
--- a/src/data.js
+++ b/src/data.js
@@ -90,13 +90,9 @@ Data.prototype = {
 
 		// Handle: [ owner, { properties } ] args
 		} else {
-			// Support an expectation from the old data system where plain
-			// objects used to initialize would be set to the cache by
-			// reference, instead of having properties and values copied.
-			// Note, this will kill the connection between
-			// "this.cache[ unlock ]" and "cache"
+			// Fresh assignments by object are shallow copied
 			if ( jQuery.isEmptyObject( cache ) ) {
-				this.cache[ unlock ] = data;
+				jQuery.extend( this.cache[ unlock ], data );
 			// Otherwise, copy the properties one-by-one to the cache object
 			} else {
 				for ( prop in data ) {
@@ -104,6 +100,7 @@ Data.prototype = {
 				}
 			}
 		}
+		return cache;
 	},
 	get: function( owner, key ) {
 		// Either a valid cache is found, or will be created.
diff --git a/src/manipulation.js b/src/manipulation.js
index e323a10ec..55d6e8510 100644
--- a/src/manipulation.js
+++ b/src/manipulation.js
@@ -527,11 +527,9 @@ function cloneCopyEvent( src, dest ) {
 	// 1. Copy private data: events, handlers, etc.
 	if ( data_priv.hasData( src ) ) {
 		pdataOld = data_priv.access( src );
-		pdataCur = jQuery.extend( {}, pdataOld );
+		pdataCur = data_priv.set( dest, pdataOld );
 		events = pdataOld.events;
 
-		data_priv.set( dest, pdataCur );
-
 		if ( events ) {
 			delete pdataCur.handle;
 			pdataCur.events = {};
diff --git a/test/unit/data.js b/test/unit/data.js
index a0361504a..c2cfe3f3f 100644
--- a/test/unit/data.js
+++ b/test/unit/data.js
@@ -244,6 +244,18 @@ test("jQuery(plain Object).data(String, Object).data(String)", function() {
 	deepEqual( $obj[0], { exists: true }, "removeData does not clear the object" );
 });
 
+test(".data(object) does not retain references. #13815", function() {
+	expect( 2 );
+
+	var $divs = jQuery("<div></div><div></div>").appendTo("#qunit-fixture");
+
+	$divs.data({ "type": "foo" });
+	$divs.eq( 0 ).data( "type", "bar" );
+
+	equal( $divs.eq( 0 ).data("type"), "bar", "Correct updated value" );
+	equal( $divs.eq( 1 ).data("type"), "foo", "Original value retained" );
+});
+
 test("data-* attributes", function() {
 	expect(40);
 	var prop, i, l, metadata, elem,