From: Stas Vilchik <stas.vilchik@sonarsource.com>
Date: Tue, 3 Oct 2017 16:55:27 +0000 (+0200)
Subject: SONAR-9496 group changelog events by action and date
X-Git-Tag: 6.6-RC1~62
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=56f06b7ea6456a56defd8eebe5f12bfe5163df6f;p=sonarqube.git

SONAR-9496 group changelog events by action and date
---

diff --git a/server/sonar-web/src/main/js/apps/quality-profiles/changelog/Changelog.tsx b/server/sonar-web/src/main/js/apps/quality-profiles/changelog/Changelog.tsx
index 021f1d3dca0..422ee1b8a81 100644
--- a/server/sonar-web/src/main/js/apps/quality-profiles/changelog/Changelog.tsx
+++ b/server/sonar-web/src/main/js/apps/quality-profiles/changelog/Changelog.tsx
@@ -19,11 +19,13 @@
  */
 import * as React from 'react';
 import { Link } from 'react-router';
+import { sortBy } from 'lodash';
+import { isSameMinute, startOfMinute } from 'date-fns';
 import ChangesList from './ChangesList';
 import DateTimeFormatter from '../../../components/intl/DateTimeFormatter';
 import { translate } from '../../../helpers/l10n';
 import { getRulesUrl } from '../../../helpers/urls';
-import { differenceInSeconds, parseDate } from '../../../helpers/dates';
+import { parseDate } from '../../../helpers/dates';
 import { ProfileChangelogEvent } from '../types';
 
 interface Props {
@@ -33,11 +35,16 @@ interface Props {
 
 export default function Changelog(props: Props) {
   let isEvenRow = false;
+  const sortedRows = sortBy(
+    props.events,
+    // sort events by date, rounded to a minute, recent events first
+    e => -Number(startOfMinute(parseDate(e.date))),
+    e => e.action
+  );
 
-  const rows = props.events.map((event, index) => {
-    const prev = index > 0 ? props.events[index - 1] : null;
-    const isSameDate =
-      prev != null && differenceInSeconds(parseDate(prev.date), parseDate(event.date)) < 10;
+  const rows = sortedRows.map((event, index) => {
+    const prev = index > 0 ? sortedRows[index - 1] : null;
+    const isSameDate = prev != null && isSameMinute(parseDate(prev.date), parseDate(event.date));
     const isBulkChange =
       prev != null &&
       isSameDate &&