From: Toshi MARUYAMA <marutosijp2@yahoo.co.jp>
Date: Tue, 24 Sep 2019 15:56:51 +0000 (+0000)
Subject: code cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb
X-Git-Tag: 4.1.0~557
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=591d0eae799968578f1fd0d5e3b37a5ee8515d4a;p=redmine.git

code cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18523 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 9afd19ed3..d9971b00c 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1726,7 +1726,6 @@ Style/WordArray:
 Style/ZeroLengthPredicate:
   Exclude:
     - 'app/models/import.rb'
-    - 'app/models/issue.rb'
     - 'app/models/mail_handler.rb'
     - 'app/models/user.rb'
     - 'lib/redmine/field_format.rb'
diff --git a/app/models/issue.rb b/app/models/issue.rb
index 6bfdaa433..8f74ec44e 100644
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -77,7 +77,7 @@ class Issue < ActiveRecord::Base
   }
 
   scope :open, lambda {|*args|
-    is_closed = args.size > 0 ? !args.first : false
+    is_closed = !args.empty? ? !args.first : false
     joins(:status).
     where(:issue_statuses => {:is_closed => is_closed})
   }