From: simonbrandhof <simon.brandhof@gmail.com>
Date: Tue, 28 Sep 2010 14:00:20 +0000 (+0000)
Subject: SONAR-1814 add a warning when a ExtensionProvider class is registered in Plugin.getEx... 
X-Git-Tag: 2.6~926
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=5cdbf337fef2559593e53dc7b2a2c68d8e1f992f;p=sonarqube.git

SONAR-1814 add a warning when a ExtensionProvider class is registered in Plugin.getExtensions()
---

diff --git a/sonar-core/src/main/java/org/sonar/core/plugin/AbstractPluginRepository.java b/sonar-core/src/main/java/org/sonar/core/plugin/AbstractPluginRepository.java
index 24a40d9fd68..b62bf983045 100644
--- a/sonar-core/src/main/java/org/sonar/core/plugin/AbstractPluginRepository.java
+++ b/sonar-core/src/main/java/org/sonar/core/plugin/AbstractPluginRepository.java
@@ -102,7 +102,15 @@ public abstract class AbstractPluginRepository implements PluginRepository {
   }
 
   protected static boolean isExtensionProvider(Object extension) {
-    return extension instanceof ExtensionProvider;
+    boolean is = false;
+    if (isType(extension, ExtensionProvider.class)) {
+      if (extension instanceof ExtensionProvider) {
+        is = true;
+      } else {
+        LOG.error("The following ExtensionProvider must be registered in Plugin.getExtensions() as an instance but not a class: " + extension);
+      }
+    }
+    return is;
   }
 
   protected static Object getExtensionKey(Object component) {