From: Scott González <scott.gonzalez@gmail.com>
Date: Tue, 23 Oct 2012 15:45:16 +0000 (-0400)
Subject: Widget: Fixed $.widget.extend() to never copy objects by reference.
X-Git-Tag: 1.9.1~19
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=5e0a2ca1e502c482e3e281d07a37558b75ce3308;p=jquery-ui.git

Widget: Fixed $.widget.extend() to never copy objects by reference.
---

diff --git a/ui/jquery.ui.widget.js b/ui/jquery.ui.widget.js
index 59fd81b9e..05487f7ed 100644
--- a/ui/jquery.ui.widget.js
+++ b/ui/jquery.ui.widget.js
@@ -142,9 +142,14 @@ $.widget.extend = function( target ) {
 	for ( ; inputIndex < inputLength; inputIndex++ ) {
 		for ( key in input[ inputIndex ] ) {
 			value = input[ inputIndex ][ key ];
-			if (input[ inputIndex ].hasOwnProperty( key ) && value !== undefined ) {
-				if ( $.isPlainObject( value ) && $.isPlainObject( target[ key ] ) ) {
-					target[ key ] = $.widget.extend( {}, target[ key ], value );
+			if ( input[ inputIndex ].hasOwnProperty( key ) && value !== undefined ) {
+				// Clone objects
+				if ( $.isPlainObject( value ) ) {
+					target[ key ] = $.isPlainObject( target[ key ] ) ?
+						$.widget.extend( {}, target[ key ], value ) :
+						// Don't extend strings, arrays, etc. with objects
+						$.widget.extend( {}, value );
+				// Copy everything else by reference
 				} else {
 					target[ key ] = value;
 				}