From: Maria Odea B. Ching Date: Thu, 7 Apr 2011 12:01:59 +0000 (+0000) Subject: [MRM-1480]/[REDBACK-274] (CVE-2011-1026) X-Git-Tag: archiva-1.3.5^2~15 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=622d4ecd46de0e48a8233542a89892eedbeefec4;p=archiva.git [MRM-1480]/[REDBACK-274] (CVE-2011-1026) o upgrade to redback 1.2.8-SNAPSHOT o configured struts2's token interceptor + use of in affected actions to prevent CSRF issue git-svn-id: https://svn.apache.org/repos/asf/archiva/branches/archiva-1.3.x@1089839 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/archiva-modules/archiva-web/archiva-webapp-test/pom.xml b/archiva-modules/archiva-web/archiva-webapp-test/pom.xml index bf5b98a5b..037b7ae39 100644 --- a/archiva-modules/archiva-web/archiva-webapp-test/pom.xml +++ b/archiva-modules/archiva-web/archiva-webapp-test/pom.xml @@ -23,7 +23,7 @@ org.apache.archiva archiva-web - 1.3.5-SNAPSHOT + 1.3.6-SNAPSHOT archiva-webapp-test pom diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/resources/struts.xml b/archiva-modules/archiva-web/archiva-webapp/src/main/resources/struts.xml index fb2db2159..58ac529aa 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/resources/struts.xml +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/resources/struts.xml @@ -47,6 +47,9 @@ false + + * + input,back,cancel,browse @@ -65,6 +68,9 @@ false + + * + input,back,cancel,browse @@ -133,6 +139,7 @@ include a result for 'error' --> /WEB-INF/jsp/generalError.jsp /WEB-INF/jsp/accessToNoRepos.jsp + /WEB-INF/jsp/redback/invalidToken.jsp @@ -179,6 +186,9 @@ /WEB-INF/jsp/deleteArtifact.jsp /WEB-INF/jsp/deleteArtifact.jsp /WEB-INF/jsp/deleteArtifact.jsp + + doDelete + @@ -253,19 +263,25 @@ /WEB-INF/jsp/admin/repositoryGroups.jsp /WEB-INF/jsp/admin/repositoryGroups.jsp repositoryGroups - + + * + /WEB-INF/jsp/admin/deleteRepositoryGroup.jsp - + + * + /WEB-INF/jsp/admin/deleteRepositoryGroup.jsp /WEB-INF/jsp/admin/deleteRepositoryGroup.jsp repositoryGroups - + + * + @@ -325,14 +341,18 @@ /WEB-INF/jsp/admin/deleteRepository.jsp - + + * + /WEB-INF/jsp/admin/deleteRepository.jsp /WEB-INF/jsp/admin/deleteRepository.jsp repositories - + + * + @@ -394,7 +414,9 @@ /WEB-INF/jsp/admin/deleteProxyConnector.jsp proxyConnectors - + + * + @@ -406,7 +428,9 @@ /WEB-INF/jsp/admin/disableProxyConnector.jsp proxyConnectors - + + * + @@ -431,13 +455,17 @@ /WEB-INF/jsp/admin/editNetworkProxy.jsp networkProxies - + + * + /WEB-INF/jsp/admin/deleteNetworkProxy.jsp networkProxies - + + * + @@ -447,6 +475,9 @@ repositoryScanning + + removeFiletypePattern,addFiletypePattern,updateKnownConsumers,updateInvalidConsumers + @@ -456,6 +487,9 @@ database + + updateSchedule,updateUnprocessedConsumers,updateCleanupConsumers + @@ -504,7 +538,9 @@ /WEB-INF/jsp/admin/legacyArtifactPath.jsp /WEB-INF/jsp/admin/legacyArtifactPath.jsp legacyArtifactPath - + + * + diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/database.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/database.jsp index 23dfa4155..8122764bb 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/database.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/database.jsp @@ -48,6 +48,7 @@ + @@ -74,6 +75,7 @@ +
@@ -129,6 +131,7 @@ +
 
diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteNetworkProxy.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteNetworkProxy.jsp index cdd817d9d..19156a36e 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteNetworkProxy.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteNetworkProxy.jsp @@ -46,6 +46,7 @@ + diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteProxyConnector.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteProxyConnector.jsp index 3a12af02f..fb56d264e 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteProxyConnector.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteProxyConnector.jsp @@ -47,6 +47,7 @@ + diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteRepository.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteRepository.jsp index 9c6b42db1..5f925e579 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteRepository.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteRepository.jsp @@ -63,6 +63,7 @@ +
diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteRepositoryGroup.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteRepositoryGroup.jsp index 83d130f25..69bbd0db4 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteRepositoryGroup.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/deleteRepositoryGroup.jsp @@ -56,6 +56,7 @@
+
diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/disableProxyConnector.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/disableProxyConnector.jsp index b496b4122..52c69ba8c 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/disableProxyConnector.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/disableProxyConnector.jsp @@ -43,6 +43,7 @@ +
diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/editNetworkProxy.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/editNetworkProxy.jsp index 29f8ffef6..f7dd33ec0 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/editNetworkProxy.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/editNetworkProxy.jsp @@ -50,6 +50,7 @@ + diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/legacyArtifactPath.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/legacyArtifactPath.jsp index 0a0167c62..2cb6bdcae 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/legacyArtifactPath.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/legacyArtifactPath.jsp @@ -73,8 +73,11 @@
<%-- TODO: make some icons --%> + + struts.token + " alt="" width="16" height="16"/> diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/networkProxies.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/networkProxies.jsp index 44eb18a04..33aec91c5 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/networkProxies.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/networkProxies.jsp @@ -71,11 +71,14 @@
+ + struts.token + " /> diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/proxyConnectors.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/proxyConnectors.jsp index 83a915c86..c42ba4f54 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/proxyConnectors.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/proxyConnectors.jsp @@ -113,6 +113,7 @@
+ @@ -128,6 +129,8 @@ + struts.token + @@ -136,6 +139,8 @@ + struts.token + diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositories.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositories.jsp index 21e584e0f..8050fc39f 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositories.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositories.jsp @@ -88,8 +88,11 @@ + + struts.token + " alt="" width="16" height="16"/> @@ -299,8 +302,11 @@ " alt="" width="16" height="16"/> Edit + + struts.token + " alt="" width="16" height="16"/> diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryGroups.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryGroups.jsp index 5804cbb95..ec7c8c2dd 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryGroups.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryGroups.jsp @@ -50,6 +50,7 @@ Identifier*: + @@ -71,8 +72,11 @@
+ + struts.token + diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryScanning.jsp b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryScanning.jsp index 60b59c7f6..5617d5c8f 100644 --- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryScanning.jsp +++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/admin/repositoryScanning.jsp @@ -40,29 +40,31 @@ - - - + + +