From: Simon Brandhof <simon.brandhof@sonarsource.com>
Date: Mon, 26 Mar 2018 15:57:26 +0000 (+0200)
Subject: SONAR-10317 Make visibility param public in WS api/projects/create and api/views... 
X-Git-Tag: 7.5~1453
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=636acf38752ef88fb3bee29186d0c8e19e43baf9;p=sonarqube.git

SONAR-10317 Make visibility param public in WS api/projects/create and api/views/create
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/project/ws/CreateAction.java b/server/sonar-server/src/main/java/org/sonar/server/project/ws/CreateAction.java
index 3dc2d6ad393..de8d06b77cf 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/project/ws/CreateAction.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/project/ws/CreateAction.java
@@ -77,7 +77,8 @@ public class CreateAction implements ProjectsWsAction {
 
     action.setChangelog(
       new Change("6.3", "The response format has been updated and does not contain the database ID anymore"),
-      new Change("6.3", "The 'key' parameter has been renamed 'project'"));
+      new Change("6.3", "The 'key' parameter has been renamed 'project'"),
+      new Change("7.1", "The 'visibility' parameter is public"));
 
     action.createParam(PARAM_PROJECT)
       .setDescription("Key of the project")
@@ -100,7 +101,6 @@ public class CreateAction implements ProjectsWsAction {
       .setDescription("Whether the created project should be visible to everyone, or only specific user/groups.<br/>" +
         "If no visibility is specified, the default project visibility of the organization will be used.")
       .setRequired(false)
-      .setInternal(true)
       .setSince("6.4")
       .setPossibleValues(Visibility.getLabels());
 
diff --git a/server/sonar-server/src/test/java/org/sonar/server/project/ws/CreateActionTest.java b/server/sonar-server/src/test/java/org/sonar/server/project/ws/CreateActionTest.java
index 15f597352ba..31d3936a36c 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/project/ws/CreateActionTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/project/ws/CreateActionTest.java
@@ -322,12 +322,12 @@ public class CreateActionTest {
     assertThat(organization.isRequired()).isFalse();
     assertThat(organization.since()).isEqualTo("6.3");
 
-    WebService.Param isPrivate = definition.param(PARAM_VISIBILITY);
-    assertThat(isPrivate.description()).isNotEmpty();
-    assertThat(isPrivate.isInternal()).isTrue();
-    assertThat(isPrivate.isRequired()).isFalse();
-    assertThat(isPrivate.since()).isEqualTo("6.4");
-    assertThat(isPrivate.possibleValues()).containsExactlyInAnyOrder("private", "public");
+    WebService.Param visibilityParam = definition.param(PARAM_VISIBILITY);
+    assertThat(visibilityParam.description()).isNotEmpty();
+    assertThat(visibilityParam.isInternal()).isFalse();
+    assertThat(visibilityParam.isRequired()).isFalse();
+    assertThat(visibilityParam.since()).isEqualTo("6.4");
+    assertThat(visibilityParam.possibleValues()).containsExactlyInAnyOrder("private", "public");
 
     WebService.Param project = definition.param(PARAM_PROJECT);
     assertThat(project.isRequired()).isTrue();