From: Joonas Lehtinen Date: Thu, 3 Jul 2008 09:13:17 +0000 (+0000) Subject: Fixes #1895 Caption is right aligned on IE on IOrderedLayoutVertical where widget... X-Git-Tag: 6.7.0.beta1~4505 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=6402343ff4ae6596d0de2f974a019371d4938025;p=vaadin-framework.git Fixes #1895 Caption is right aligned on IE on IOrderedLayoutVertical where widget is aligned right svn changeset:5018/svn branch:trunk --- diff --git a/WebContent/ITMILL/themes/default/orderedlayout/orderedlayout.css b/WebContent/ITMILL/themes/default/orderedlayout/orderedlayout.css index 591f379e5f..635fe1a3bf 100644 --- a/WebContent/ITMILL/themes/default/orderedlayout/orderedlayout.css +++ b/WebContent/ITMILL/themes/default/orderedlayout/orderedlayout.css @@ -26,10 +26,6 @@ float:left; } -.i-orderedlayout-w1 { - text-align:left; -} - .i-orderedlayout-w2 .i-caption:after, .i-orderedlayout-w2:after { content: "."; display: block; diff --git a/WebContent/ITMILL/themes/default/styles.css b/WebContent/ITMILL/themes/default/styles.css index 6067792ab4..7f1ff47834 100644 --- a/WebContent/ITMILL/themes/default/styles.css +++ b/WebContent/ITMILL/themes/default/styles.css @@ -709,10 +709,6 @@ input.i-modified, float:left; } -.i-orderedlayout-w1 { - text-align:left; -} - .i-orderedlayout-w2 .i-caption:after, .i-orderedlayout-w2:after { content: "."; display: block; diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/IOrderedLayout.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/IOrderedLayout.java index a9f196b46b..2d73acc72c 100644 --- a/src/com/itmill/toolkit/terminal/gwt/client/ui/IOrderedLayout.java +++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/IOrderedLayout.java @@ -272,9 +272,6 @@ public abstract class IOrderedLayout extends Panel implements Container { } else { setElement(DOM.createTD()); } - DOM - .setElementAttribute(getElement(), "class", - "i-orderedlayout-w1"); } public void updateCaption(UIDL uidl, Paintable paintable) { @@ -307,10 +304,8 @@ public abstract class IOrderedLayout extends Panel implements Container { .getChildCount(getElement()) - 2); DOM.removeChild(getElement(), firstElement); DOM.appendChild(getElement(), firstElement); - DOM - .setElementAttribute(getElement(), "class", - after ? "i-orderedlayout-w2" - : "i-orderedlayout-w1"); + DOM.setElementAttribute(getElement(), "class", + after ? "i-orderedlayout-w2" : ""); if (after) { widget.addStyleName("i-orderedlayout-w-e"); } else { @@ -322,8 +317,7 @@ public abstract class IOrderedLayout extends Panel implements Container { if (caption != null) { DOM.removeChild(getElement(), caption.getElement()); caption = null; - DOM.setElementAttribute(getElement(), "class", - "i-orderedlayout-w1"); + DOM.setElementAttribute(getElement(), "class", ""); widget.removeStyleName("i-orderedlayout-w-e"); } } @@ -343,6 +337,7 @@ public abstract class IOrderedLayout extends Panel implements Container { void setAlignment(String verticalAlignment, String horizontalAlignment) { // Set vertical alignment + if (BrowserInfo.get().isIE()) { DOM.setElementAttribute(getElement(), "vAlign", verticalAlignment); @@ -385,9 +380,7 @@ public abstract class IOrderedLayout extends Panel implements Container { DOM.setStyleAttribute(table, "width", "100%"); DOM.setElementAttribute(itable, "cellpadding", "0"); DOM.setElementAttribute(itable, "cellspacing", "0"); - // TODO DOM.setStyleAttribute(itd, "align", "left"); - // TODO DEBUG DOM.setStyleAttribute(itd, "border", "1px - // solid red"); + DOM.setElementAttribute(itd, "align", "left"); // move possible content to cell while (DOM.getChildCount(getElement()) > 0) {