From: Teryk Bellahsene <teryk.bellahsene@sonarsource.com>
Date: Wed, 11 Apr 2018 13:44:51 +0000 (+0200)
Subject: SONAR-10570 Do not return an empty pull request URL when it's not provided
X-Git-Tag: 7.5~1296
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=64a7ab5038ad34b5aadb75707109f31d9d8b990e;p=sonarqube.git

SONAR-10570 Do not return an empty pull request URL when it's not provided
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/branch/pr/ws/ListAction.java b/server/sonar-server/src/main/java/org/sonar/server/branch/pr/ws/ListAction.java
index 62618d2e359..a1ccc974a37 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/branch/pr/ws/ListAction.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/branch/pr/ws/ListAction.java
@@ -43,6 +43,7 @@ import org.sonar.server.user.UserSession;
 import org.sonarqube.ws.ProjectPullRequests;
 
 import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Strings.emptyToNull;
 import static java.util.Collections.singletonList;
 import static java.util.Objects.requireNonNull;
 import static org.sonar.api.measures.CoreMetrics.ALERT_STATUS_KEY;
@@ -140,8 +141,8 @@ public class ListAction implements PullRequestWsAction {
 
     DbProjectBranches.PullRequestData pullRequestData = requireNonNull(branch.getPullRequestData(), "Pull request data should be available for branch type PULL_REQUEST");
     builder.setBranch(pullRequestData.getBranch());
-    builder.setUrl(pullRequestData.getUrl());
-    builder.setTitle(pullRequestData.getTitle());
+    setNullable(emptyToNull(pullRequestData.getUrl()), builder::setUrl);
+    setNullable(emptyToNull(pullRequestData.getTitle()), builder::setTitle);
 
     if (mergeBranch.isPresent()) {
       String mergeBranchKey = mergeBranch.get().getKey();
diff --git a/server/sonar-server/src/test/java/org/sonar/server/branch/pr/ws/ListActionTest.java b/server/sonar-server/src/test/java/org/sonar/server/branch/pr/ws/ListActionTest.java
index b42d3df7af1..25aefe358fc 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/branch/pr/ws/ListActionTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/branch/pr/ws/ListActionTest.java
@@ -153,8 +153,8 @@ public class ListActionTest {
       .executeProtobuf(ListWsResponse.class);
 
     assertThat(response.getPullRequestsList())
-      .extracting(PullRequest::getKey, PullRequest::getBranch, PullRequest::getIsOrphan)
-      .containsExactlyInAnyOrder(tuple("123", "feature/bar", false));
+      .extracting(PullRequest::getKey, PullRequest::getBranch, PullRequest::getIsOrphan, PullRequest::hasUrl, PullRequest::hasTitle)
+      .containsExactlyInAnyOrder(tuple("123", "feature/bar", false, false, false));
   }
 
   @Test