From: Teppo Kurki <teppo.kurki@vaadin.com>
Date: Mon, 30 Dec 2013 19:47:18 +0000 (+0200)
Subject: Properly remove shadow event listeners to prevent IE8 memory leak (#13129)
X-Git-Tag: 7.1.10~19
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=65c2f2bf06986d397169e58f819ba1592fa52bb7;p=vaadin-framework.git

Properly remove shadow event listeners to prevent IE8 memory leak (#13129)

Change-Id: I98becf08f56ce35a3ee47650d0d4e204e7d18e73
---

diff --git a/client/src/com/vaadin/client/ui/VOverlay.java b/client/src/com/vaadin/client/ui/VOverlay.java
index 2f5df6d4f3..e2c9001fed 100644
--- a/client/src/com/vaadin/client/ui/VOverlay.java
+++ b/client/src/com/vaadin/client/ui/VOverlay.java
@@ -241,10 +241,10 @@ public class VOverlay extends PopupPanel implements CloseHandler<PopupPanel> {
 
     private void removeShadowIfPresent() {
         if (isShadowAttached()) {
-            shadow.removeFromParent();
-
             // Remove event listener from the shadow
             unsinkShadowEvents();
+
+            shadow.removeFromParent();
         }
     }