From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Fri, 15 Mar 2019 07:30:02 +0000 (+0000)
Subject: Merged r17949 to 3.4-stable (#29055).
X-Git-Tag: 3.4.10~5
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=6626f87e55124d193029920b8660313d31a9c2c7;p=redmine.git

Merged r17949 to 3.4-stable (#29055).

git-svn-id: http://svn.redmine.org/redmine/branches/3.4-stable@17951 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb
index 486029fc9..ce9e21f1d 100644
--- a/app/controllers/search_controller.rb
+++ b/app/controllers/search_controller.rb
@@ -37,7 +37,7 @@ class SearchController < ApplicationController
     end
 
     # quick jump to an issue
-    if (m = @question.match(/^#?(\d+)$/)) && (issue = Issue.visible.find_by_id(m[1].to_i))
+    if !api_request? && (m = @question.match(/^#?(\d+)$/)) && (issue = Issue.visible.find_by_id(m[1].to_i))
       redirect_to issue_path(issue)
       return
     end
diff --git a/test/integration/api_test/search_test.rb b/test/integration/api_test/search_test.rb
index 2c14ed4ac..354f5f27b 100644
--- a/test/integration/api_test/search_test.rb
+++ b/test/integration/api_test/search_test.rb
@@ -89,4 +89,9 @@ class Redmine::ApiTest::SearchTest < Redmine::ApiTest::Base
     assert_equal 4, json['limit']
     assert_equal issue[8..10], json['results'].map {|r| r['id']}
   end
+ 
+  test "GET /search.xml should not quick jump to the issue with given id" do
+    get '/search.xml', :params => {:q => '3'}
+    assert_response :success
+  end
 end