From: Grégoire Aubert Date: Fri, 25 Aug 2017 09:04:36 +0000 (+0200) Subject: Invert y axis of project and coverage overview bubblecharts on measures page X-Git-Tag: 6.6-RC1~527 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=674c28368e61d82b2b14dc5d77b21e411f05d30d;p=sonarqube.git Invert y axis of project and coverage overview bubblecharts on measures page --- diff --git a/server/sonar-web/src/main/js/apps/component-measures/config/bubbles.js b/server/sonar-web/src/main/js/apps/component-measures/config/bubbles.js index 12aa314d30b..04ead5c4e4e 100644 --- a/server/sonar-web/src/main/js/apps/component-measures/config/bubbles.js +++ b/server/sonar-web/src/main/js/apps/component-measures/config/bubbles.js @@ -37,12 +37,13 @@ export const bubbles = { size: 'code_smells', colors: ['sqale_rating'] }, - Coverage: { x: 'complexity', y: 'coverage', size: 'uncovered_lines' }, + Coverage: { x: 'complexity', y: 'coverage', size: 'uncovered_lines', yDomain: [100, 0] }, Duplications: { x: 'ncloc', y: 'duplicated_lines', size: 'duplicated_blocks' }, project_overview: { x: 'sqale_index', y: 'coverage', size: 'ncloc', - colors: ['reliability_rating', 'security_rating'] + colors: ['reliability_rating', 'security_rating'], + yDomain: [100, 0] } }; diff --git a/server/sonar-web/src/main/js/apps/component-measures/drilldown/BubbleChart.js b/server/sonar-web/src/main/js/apps/component-measures/drilldown/BubbleChart.js index dd333e09067..a57d110e5ea 100644 --- a/server/sonar-web/src/main/js/apps/component-measures/drilldown/BubbleChart.js +++ b/server/sonar-web/src/main/js/apps/component-measures/drilldown/BubbleChart.js @@ -29,7 +29,7 @@ import { translate, translateWithParameters } from '../../../helpers/l10n'; -import { getBubbleMetrics, isProjectOverview } from '../utils'; +import { getBubbleMetrics, getBubbleYDomain, isProjectOverview } from '../utils'; import { RATING_COLORS } from '../../../helpers/constants'; /*:: import type { Component, ComponentEnhanced } from '../types'; */ /*:: import type { Metric } from '../../../store/metrics/actions'; */ @@ -131,6 +131,7 @@ export default class BubbleChart extends React.PureComponent { formatXTick={formatXTick} formatYTick={formatYTick} onBubbleClick={this.handleBubbleClick} + yDomain={getBubbleYDomain(this.props.domain)} /> ); } diff --git a/server/sonar-web/src/main/js/apps/component-measures/utils.js b/server/sonar-web/src/main/js/apps/component-measures/utils.js index ff80141bc78..b3db6ba1baa 100644 --- a/server/sonar-web/src/main/js/apps/component-measures/utils.js +++ b/server/sonar-web/src/main/js/apps/component-measures/utils.js @@ -150,6 +150,10 @@ export function getBubbleMetrics(domain /*: string */, metrics /*: { [string]: M }; } +export function getBubbleYDomain(domain /*: string */) { + return bubbles[domain].yDomain; +} + export function isProjectOverview(metric /*: string */) { return metric === PROJECT_OVERVEW; }