From: Stas Vilchik <vilchiks@gmail.com>
Date: Thu, 19 Nov 2015 10:11:34 +0000 (+0100)
Subject: fix measure formatting when empty string is passed
X-Git-Tag: 5.3-RC1~222
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=680eb44f7a4fee9d6a3c5d38b09233dec0ffa8ed;p=sonarqube.git

fix measure formatting when empty string is passed
---

diff --git a/server/sonar-web/src/main/js/helpers/measures.js b/server/sonar-web/src/main/js/helpers/measures.js
index 23a27e9270e..dd8b4ea5854 100644
--- a/server/sonar-web/src/main/js/helpers/measures.js
+++ b/server/sonar-web/src/main/js/helpers/measures.js
@@ -56,7 +56,7 @@ export function groupByDomain (metrics) {
  */
 
 function useFormatter (value, formatter) {
-  return value != null && formatter != null ?
+  return value != null && value !== '' && formatter != null ?
       formatter(value) : null;
 }
 
diff --git a/server/sonar-web/tests/helpers/measures-test.js b/server/sonar-web/tests/helpers/measures-test.js
index e302e2db0ab..503d6e3214a 100644
--- a/server/sonar-web/tests/helpers/measures-test.js
+++ b/server/sonar-web/tests/helpers/measures-test.js
@@ -146,6 +146,10 @@ describe('Measures', function () {
       expect(formatMeasure('random value', 'RANDOM_TYPE')).to.equal('random value');
     });
 
+    it('should return null if value is empty string', function () {
+      expect(formatMeasure('', 'PERCENT')).to.be.null;
+    });
+
     it('should not fail without parameters', function () {
       expect(formatMeasure()).to.be.null;
     });