From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Fri, 29 Mar 2024 17:04:38 +0000 (+0100)
Subject: fix(files_sharing): Disable autocomplete for share label and password
X-Git-Tag: v29.0.0rc2~6^2~1
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=68402768db5d0663ad9310743a74d18e4e6ce706;p=nextcloud-server.git

fix(files_sharing): Disable autocomplete for share label and password

Prevent browsers - as good as possible - from filling in user credentials as share label and password.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---

diff --git a/apps/files_sharing/src/views/SharingDetailsTab.vue b/apps/files_sharing/src/views/SharingDetailsTab.vue
index 92222a05c5a..e852a0f8599 100644
--- a/apps/files_sharing/src/views/SharingDetailsTab.vue
+++ b/apps/files_sharing/src/views/SharingDetailsTab.vue
@@ -101,14 +101,15 @@
 				role="region">
 				<section>
 					<NcInputField v-if="isPublicShare"
-						:value.sync="share.label"
-						type="text"
-						:label="t('files_sharing', 'Share label')" />
+						autocomplete="off"
+						:label="t('files_sharing', 'Share label')"
+						:value.sync="share.label" />
 					<template v-if="isPublicShare">
 						<NcCheckboxRadioSwitch :checked.sync="isPasswordProtected" :disabled="isPasswordEnforced">
 							{{ t('files_sharing', 'Set password') }}
 						</NcCheckboxRadioSwitch>
 						<NcPasswordField v-if="isPasswordProtected"
+							autocomplete="new-password"
 							:value="hasUnsavedPassword ? share.newPassword : ''"
 							:error="passwordError"
 							:helper-text="errorPasswordLabel"