From: Javen O'Neal <onealj@apache.org>
Date: Mon, 13 Jun 2016 05:34:02 +0000 (+0000)
Subject: findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=6c5cd8e400ad4d901802ae024f78eff5e56a39eb;p=poi.git

findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748086 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTable.java b/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTable.java
index d512521388..2e4bb5c809 100644
--- a/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTable.java
+++ b/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTable.java
@@ -74,7 +74,8 @@ public class XWPFTable implements IBodyElement, ISDTContents {
     protected StringBuffer text = new StringBuffer();
     protected List<XWPFTableRow> tableRows;
 
-    protected List<String> styleIDs;
+    // Unused: UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD
+    //protected List<String> styleIDs;
     protected IBody part;
     private CTTbl ctTbl;
 
diff --git a/src/resources/devtools/findbugs-filters.xml b/src/resources/devtools/findbugs-filters.xml
index 318db2b114..eedae72994 100644
--- a/src/resources/devtools/findbugs-filters.xml
+++ b/src/resources/devtools/findbugs-filters.xml
@@ -74,6 +74,14 @@
 		<Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" />
 		<Field name="compression" />
 	</Match>
+	<Match>
+		<Class name="org.apache.poi.hwmf.record.HwmfFont"/>
+		<Bug pattern="UUF_UNUSED_FIELD" />
+		<Or>
+			<Field name="family" />
+			<Field name="pitch" />
+		</Or>
+	</Match>
 	
 
     <!-- invalid performance issues - e.g. see #57840 -->