From: Kevin Silva <kevin.silva@sonarsource.com>
Date: Mon, 24 Jul 2023 15:16:55 +0000 (+0200)
Subject: SONAR-20010 - Project List improvements
X-Git-Tag: 10.2.0.77647~300
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=6d373c90f7737e245a3f3aca1d509da91b1f3429;p=sonarqube.git

SONAR-20010 - Project List improvements
---

diff --git a/server/sonar-web/src/main/js/apps/projectInformation/__tests__/ProjectInformationApp-it.tsx b/server/sonar-web/src/main/js/apps/projectInformation/__tests__/ProjectInformationApp-it.tsx
index ab0076ae275..1041565c05b 100644
--- a/server/sonar-web/src/main/js/apps/projectInformation/__tests__/ProjectInformationApp-it.tsx
+++ b/server/sonar-web/src/main/js/apps/projectInformation/__tests__/ProjectInformationApp-it.tsx
@@ -134,7 +134,7 @@ it('should hide some fields for application', async () => {
   });
   expect(await ui.applicationPageTitle.find()).toBeInTheDocument();
   expect(screen.getByText('application.info.empty_description')).toBeInTheDocument();
-  expect(screen.queryByText(/visibility/)).not.toBeInTheDocument();
+  expect(screen.getByText('visibility.public')).toBeInTheDocument();
   expect(ui.tags.get()).toHaveTextContent('no_tags');
 });
 
@@ -146,7 +146,7 @@ it('should not show field that is not configured', async () => {
   expect(await ui.projectPageTitle.find()).toBeInTheDocument();
   expect(ui.qualityGateList.query()).not.toBeInTheDocument();
   expect(ui.qualityProfilesList.query()).not.toBeInTheDocument();
-  expect(screen.queryByText(/visibility/)).not.toBeInTheDocument();
+  expect(screen.getByText('visibility.public')).toBeInTheDocument();
   expect(ui.tags.get()).toHaveTextContent('no_tags');
   expect(screen.getByText('project.info.empty_description')).toBeInTheDocument();
 });
@@ -160,7 +160,7 @@ it('should hide visibility if public', async () => {
   expect(await ui.projectPageTitle.find()).toBeInTheDocument();
   expect(ui.qualityGateList.query()).not.toBeInTheDocument();
   expect(ui.qualityProfilesList.query()).not.toBeInTheDocument();
-  expect(screen.queryByText(/visibility/)).not.toBeInTheDocument();
+  expect(screen.getByText('visibility.public')).toBeInTheDocument();
   expect(ui.tags.get()).toHaveTextContent('no_tags');
   expect(screen.getByText('project.info.empty_description')).toBeInTheDocument();
 });
diff --git a/server/sonar-web/src/main/js/apps/projectInformation/about/AboutProject.tsx b/server/sonar-web/src/main/js/apps/projectInformation/about/AboutProject.tsx
index c148d441475..168c2dc593f 100644
--- a/server/sonar-web/src/main/js/apps/projectInformation/about/AboutProject.tsx
+++ b/server/sonar-web/src/main/js/apps/projectInformation/about/AboutProject.tsx
@@ -78,11 +78,12 @@ export default function AboutProject(props: AboutProjectProps) {
         <MetaKey componentKey={component.key} qualifier={component.qualifier} />
       </ProjectInformationSection>
 
-      {component.visibility === Visibility.Private && (
-        <ProjectInformationSection>
-          <MetaVisibility qualifier={component.qualifier} visibility={component.visibility} />
-        </ProjectInformationSection>
-      )}
+      <ProjectInformationSection>
+        <MetaVisibility
+          qualifier={component.qualifier}
+          visibility={component.visibility ?? Visibility.Public}
+        />
+      </ProjectInformationSection>
 
       <ProjectInformationSection>
         <MetaDescription description={component.description} isApp={isApp} />
diff --git a/server/sonar-web/src/main/js/apps/projects/components/project-card/ProjectCard.tsx b/server/sonar-web/src/main/js/apps/projects/components/project-card/ProjectCard.tsx
index c3e7ac009fb..2b5118b3576 100644
--- a/server/sonar-web/src/main/js/apps/projects/components/project-card/ProjectCard.tsx
+++ b/server/sonar-web/src/main/js/apps/projects/components/project-card/ProjectCard.tsx
@@ -43,7 +43,7 @@ import Measure from '../../../../components/measure/Measure';
 import { translate, translateWithParameters } from '../../../../helpers/l10n';
 import { formatMeasure } from '../../../../helpers/measures';
 import { getProjectUrl } from '../../../../helpers/urls';
-import { ComponentQualifier, Visibility } from '../../../../types/component';
+import { ComponentQualifier } from '../../../../types/component';
 import { MetricKey, MetricType } from '../../../../types/metrics';
 import { Status } from '../../../../types/types';
 import { CurrentUser, isLoggedIn } from '../../../../types/users';
@@ -81,13 +81,12 @@ function renderFirstLine(
             />
           )}
 
-          <h3 className="it__project-card-name" title={name}>
+          <h1 className="it__project-card-name" title={name}>
             <StandoutLink to={getProjectUrl(key)}>{name}</StandoutLink>
-          </h3>
+          </h1>
 
           {qualifier === ComponentQualifier.Application && (
             <Tooltip
-              placement="top"
               overlay={
                 <span>
                   {translate('qualifier.APP')}
@@ -101,20 +100,16 @@ function renderFirstLine(
               }
             >
               <span>
-                <Badge className="sw-ml-2 sw-font-sans">{translate('qualifier.APP')}</Badge>
+                <Badge className="sw-ml-2">{translate('qualifier.APP')}</Badge>
               </span>
             </Tooltip>
           )}
 
-          {visibility === Visibility.Private && (
-            <Tooltip overlay={translate('visibility', visibility, 'description', qualifier)}>
-              <span>
-                <Badge className="sw-ml-2 sw-font-sans">
-                  {translate('visibility', visibility)}
-                </Badge>
-              </span>
-            </Tooltip>
-          )}
+          <Tooltip overlay={translate('visibility', visibility, 'description', qualifier)}>
+            <span>
+              <Badge className="sw-ml-2">{translate('visibility', visibility)}</Badge>
+            </span>
+          </Tooltip>
         </div>
         {analysisDate && (
           <Tooltip overlay={qualityGateLabel}>
@@ -156,7 +151,7 @@ function renderFirstLine(
                       value={measures.new_lines}
                     />
                   </span>
-                  <span>{translate('metric.new_lines.name')}</span>
+                  <span className="sw-body-sm">{translate('metric.new_lines.name')}</span>
                 </div>
               </>
             )
@@ -171,7 +166,7 @@ function renderFirstLine(
                       value={measures.ncloc}
                     />
                   </span>
-                  <span>{translate('metric.ncloc.name')}</span>
+                  <span className="sw-body-sm">{translate('metric.ncloc.name')}</span>
                 </div>
                 <SeparatorCircleIcon className="sw-mx-1" />
                 <span className="sw-body-sm" data-key={MetricKey.ncloc_language_distribution}>
diff --git a/server/sonar-web/src/main/js/components/common/PrivacyBadgeContainer.tsx b/server/sonar-web/src/main/js/components/common/PrivacyBadgeContainer.tsx
index 86a203671ae..36e4b07b1cb 100644
--- a/server/sonar-web/src/main/js/components/common/PrivacyBadgeContainer.tsx
+++ b/server/sonar-web/src/main/js/components/common/PrivacyBadgeContainer.tsx
@@ -34,10 +34,6 @@ export default function PrivacyBadgeContainer({
   qualifier,
   visibility,
 }: PrivacyBadgeContainerProps) {
-  if (visibility !== Visibility.Private) {
-    return null;
-  }
-
   return (
     <Tooltip overlay={translate('visibility', visibility, 'description', qualifier)}>
       <div className={classNames('badge', className)}>{translate('visibility', visibility)}</div>
diff --git a/server/sonar-web/src/main/js/components/common/__tests__/PrivacyBadgeContainer-test.tsx b/server/sonar-web/src/main/js/components/common/__tests__/PrivacyBadgeContainer-test.tsx
index 12e905a51ab..58579fadd0d 100644
--- a/server/sonar-web/src/main/js/components/common/__tests__/PrivacyBadgeContainer-test.tsx
+++ b/server/sonar-web/src/main/js/components/common/__tests__/PrivacyBadgeContainer-test.tsx
@@ -26,7 +26,7 @@ it('renders', () => {
   expect(getWrapper()).toMatchSnapshot();
 });
 
-it('do not render', () => {
+it('should render public', () => {
   expect(getWrapper({ visibility: Visibility.Public })).toMatchSnapshot();
 });
 
diff --git a/server/sonar-web/src/main/js/components/common/__tests__/__snapshots__/PrivacyBadgeContainer-test.tsx.snap b/server/sonar-web/src/main/js/components/common/__tests__/__snapshots__/PrivacyBadgeContainer-test.tsx.snap
index 45a670ff6a1..4bbe4a4a09a 100644
--- a/server/sonar-web/src/main/js/components/common/__tests__/__snapshots__/PrivacyBadgeContainer-test.tsx.snap
+++ b/server/sonar-web/src/main/js/components/common/__tests__/__snapshots__/PrivacyBadgeContainer-test.tsx.snap
@@ -1,7 +1,5 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`do not render 1`] = `""`;
-
 exports[`renders 1`] = `
 <Tooltip
   overlay="visibility.private.description.TRK"
@@ -13,3 +11,15 @@ exports[`renders 1`] = `
   </div>
 </Tooltip>
 `;
+
+exports[`should render public 1`] = `
+<Tooltip
+  overlay="visibility.public.description.TRK"
+>
+  <div
+    className="badge"
+  >
+    visibility.public
+  </div>
+</Tooltip>
+`;
diff --git a/server/sonar-web/src/main/js/components/controls/Tooltip.css b/server/sonar-web/src/main/js/components/controls/Tooltip.css
index e532c2a48e5..e37dfdd89a1 100644
--- a/server/sonar-web/src/main/js/components/controls/Tooltip.css
+++ b/server/sonar-web/src/main/js/components/controls/Tooltip.css
@@ -59,7 +59,6 @@
   padding: 12px 17px;
   color: #eff2f9;
   background-color: #2a2f40;
-  letter-spacing: 0.04em;
 }
 
 .tooltip-inner .alert {