From: Mario Danic <mario@lovelyhq.com>
Date: Wed, 29 Apr 2020 22:13:13 +0000 (+0200)
Subject: Add index to properties table
X-Git-Tag: v19.0.0beta7~16^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=6e28c2807b751a9dbd2a60abb3038eed3cf04b42;p=nextcloud-server.git

Add index to properties table

Signed-off-by: Mario Danic <mario@lovelyhq.com>
---

diff --git a/core/Application.php b/core/Application.php
index 2996c412553..217b6ac41e9 100644
--- a/core/Application.php
+++ b/core/Application.php
@@ -163,6 +163,13 @@ class Application extends App {
 						$subject->addHintForMissingSubject($table->getName(), 'schedulobj_principuri_index');
 					}
 				}
+
+				if ($schema->hasTable('properties')) {
+					$table = $schema->getTable('properties');
+					if (!$table->hasIndex('properties_path_index')) {
+						$subject->addHintForMissingSubject($table->getName(), 'properties_path_index');
+					}
+				}
 			}
 		);
 
diff --git a/core/Command/Db/AddMissingIndices.php b/core/Command/Db/AddMissingIndices.php
index 506fef94a63..2784721f55f 100644
--- a/core/Command/Db/AddMissingIndices.php
+++ b/core/Command/Db/AddMissingIndices.php
@@ -11,6 +11,7 @@ declare(strict_types=1);
  * @author Robin Appelman <robin@icewind.nl>
  * @author Roeland Jago Douma <roeland@famdouma.nl>
  * @author Thomas Citharel <nextcloud@tcit.fr>
+ * @author Mario Danic <mario@lovelyhq.com>
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -254,6 +255,19 @@ class AddMissingIndices extends Command {
 			}
 		}
 
+		$output->writeln('<info>Check indices of the oc_properties table.</info>');
+		if ($schema->hasTable('properties')) {
+			$table = $schema->getTable('properties');
+			if (!$table->hasIndex('properties_path_index')) {
+				$output->writeln('<info>Adding properties_path_index index to the oc_properties table, this can take some time...</info>');
+
+				$table->addIndex(['userid', 'propertypath'], 'properties_path_index');
+				$this->connection->migrateToSchema($schema->getWrappedSchema());
+				$updated = true;
+				$output->writeln('<info>oc_properties table updated successfully.</info>');
+			}
+		}
+
 		if (!$updated) {
 			$output->writeln('<info>Done.</info>');
 		}
diff --git a/core/Migrations/Version13000Date20170718121200.php b/core/Migrations/Version13000Date20170718121200.php
index f9745566168..7e48059f798 100644
--- a/core/Migrations/Version13000Date20170718121200.php
+++ b/core/Migrations/Version13000Date20170718121200.php
@@ -318,6 +318,7 @@ class Version13000Date20170718121200 extends SimpleMigrationStep {
 			]);
 			$table->setPrimaryKey(['id']);
 			$table->addIndex(['userid'], 'property_index');
+			$table->addIndex(['userid', 'propertypath'], 'properties_path_index');
 		}
 
 		if (!$schema->hasTable('share')) {